From 0c8d8f6b2e3b924c396babfa44b699ce09c91fc6 Mon Sep 17 00:00:00 2001 From: moneromooo-monero Date: Wed, 15 Aug 2018 13:09:14 +0000 Subject: [PATCH] unit_tests: remove std::move in return statement This actually prevents copy elision --- tests/unit_tests/serialization.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/unit_tests/serialization.cpp b/tests/unit_tests/serialization.cpp index 5a2114027..07e15e61e 100644 --- a/tests/unit_tests/serialization.cpp +++ b/tests/unit_tests/serialization.cpp @@ -825,7 +825,7 @@ TEST(Serialization, portability_outputs) return {}; } crypto::chacha8(ciphertext.data() + sizeof(iv), ciphertext.size() - prefix_size, key, iv, &plaintext[0]); - return std::move(plaintext); + return plaintext; }; crypto::secret_key view_secret_key; epee::string_tools::hex_to_pod("339673bb1187e2f73ba7841ab6841c5553f96e9f13f8fe6612e69318db4e9d0a", view_secret_key);