From ae3c214c3f572304b0c937726e4fdef38c09f59d Mon Sep 17 00:00:00 2001
From: tobtoht <thotbot@protonmail.com>
Date: Thu, 24 Dec 2020 13:50:20 +0100
Subject: [PATCH] TickerWidget: minor cleanup

---
 src/widgets/tickerwidget.cpp | 16 ++++++++--------
 src/widgets/tickerwidget.h   |  1 -
 2 files changed, 8 insertions(+), 9 deletions(-)

diff --git a/src/widgets/tickerwidget.cpp b/src/widgets/tickerwidget.cpp
index a180b42..17c9a47 100644
--- a/src/widgets/tickerwidget.cpp
+++ b/src/widgets/tickerwidget.cpp
@@ -50,15 +50,19 @@ void TickerWidget::init() {
     double amount = m_convertBalance ? AppContext::balance : 1.0;
     double conversion = AppContext::prices->convert(m_symbol, fiatCurrency, amount);
     if (conversion < 0) return;
-    ui->tickerPct->setHidden(conversion == 0 || m_hidePercent);
 
     auto markets = AppContext::prices->markets;
     if(!markets.contains(m_symbol)) return;
 
-    auto pct24h = markets[m_symbol].price_usd_change_pct_24h;
-    auto pct24hText = QString::number(pct24h, 'f', 2);
+    bool hidePercent = (conversion == 0 || m_hidePercent);
+    if (hidePercent) {
+        ui->tickerPct->hide();
+    } else {
+        auto pct24h = markets[m_symbol].price_usd_change_pct_24h;
+        auto pct24hText = QString::number(pct24h, 'f', 2);
+        this->setPctText(pct24hText, pct24h >= 0.0);
+    }
 
-    this->setPctText(pct24hText, pct24h >= 0.0);
     this->setFiatText(fiatCurrency, conversion);
 }
 
@@ -84,10 +88,6 @@ void TickerWidget::setFontSizes() {
     ui->tickerFiat->setFont(Utils::relativeFont(0));
 }
 
-void TickerWidget::removePctContainer() {
-    ui->tickerPct->deleteLater();
-}
-
 TickerWidget::~TickerWidget() {
     delete ui;
 }
diff --git a/src/widgets/tickerwidget.h b/src/widgets/tickerwidget.h
index 321e2c8..0955b72 100644
--- a/src/widgets/tickerwidget.h
+++ b/src/widgets/tickerwidget.h
@@ -18,7 +18,6 @@ class TickerWidget : public QWidget
 
 public:
     explicit TickerWidget(QWidget *parent, QString symbol, QString title = "", bool convertBalance = false, bool hidePercent = false);
-    void removePctContainer();
     void setFiatText(QString &fiatCurrency, double amount);
     void setPctText(QString &text, bool positive);
     void setFontSizes();