From b60a147b8bc710db9f788336f42894b6d7a5a83f Mon Sep 17 00:00:00 2001
From: moneroexamples <moneroexamples@tuta.io>
Date: Sat, 15 Feb 2020 11:07:52 +0800
Subject: [PATCH] Remove payment id to ascii conversion

https://github.com/moneroexamples/onion-monero-blockchain-explorer/issues/204
---
 src/page.h                             | 6 ------
 src/templates/partials/tx_details.html | 1 -
 2 files changed, 7 deletions(-)

diff --git a/src/page.h b/src/page.h
index 496b83d..e170d14 100644
--- a/src/page.h
+++ b/src/page.h
@@ -330,8 +330,6 @@ struct tx_details
     crypto::hash  payment_id  = null_hash; // normal
     crypto::hash8 payment_id8 = null_hash8; // encrypted
 
-    string payment_id_as_ascii;
-
     std::vector<std::vector<crypto::signature>> signatures;
 
     // key images of inputs
@@ -6038,9 +6036,6 @@ construct_tx_context(transaction tx, uint16_t with_ring_signatures = 0)
 
     string tx_json = obj_to_json_str(tx);
 
-    // use this regex to remove all non friendly characters in payment_id_as_ascii string
-    static std::regex e {"[^a-zA-Z0-9 ./\\\\!]"};
-
     double tx_size = static_cast<double>(txd.size) / 1024.0;
 
     double payed_for_kB = XMR_AMOUNT(txd.fee) / tx_size;
@@ -6069,7 +6064,6 @@ construct_tx_context(transaction tx, uint16_t with_ring_signatures = 0)
             {"has_payment_id8"       , txd.payment_id8 != null_hash8},
             {"confirmations"         , txd.no_confirmations},
             {"payment_id"            , pid_str},
-            {"payment_id_as_ascii"   , remove_bad_chars(txd.payment_id_as_ascii)},
             {"payment_id8"           , pid8_str},
             {"extra"                 , txd.get_extra_str()},
             {"with_ring_signatures"  , static_cast<bool>(
diff --git a/src/templates/partials/tx_details.html b/src/templates/partials/tx_details.html
index 7da9d24..ef217fc 100644
--- a/src/templates/partials/tx_details.html
+++ b/src/templates/partials/tx_details.html
@@ -10,7 +10,6 @@
 
     {{#has_payment_id}}
         <H5 style="margin:5px">Payment id: <span id="payment_id">{{payment_id}}</span></H5>
-        <H5 style="margin:5px">Payment id as ascii: {{payment_id_as_ascii}}</H5>
     {{/has_payment_id}}
 
     {{#has_payment_id8}}