Sending empty messages
How do you think we should check for if a message is empty? If body.trim().length
is 0
?
Refactor homeserver lookup code
Why chain a promise catch here? I don't have a problem with promise chaining, it's just weird considering that we used the try/catch syntax 3 lines up. IMO they should be made consistent?
Incorrect redirect on succesful login
Incorrect redirect on succesful login
Not entirely fixed - we need to ensure that we go to /login/
(with trailing slash) here: https://gitdab.com/cadence/Carbon/src/branch/princess/src/js/main.js#L8
Incorrect redirect on succesful login
Fish required to be installed to use watch script
Changed to use sh
shell in a56c423. A true multi-platform solution will come in the future when the file watcher is built into the node build script.
Fish required to be installed to use watch script