cadence

cadence commented on pull request cadence/Carbon#24

2020-10-29 07:46:58 +00:00

Rich message rendering

Not sure how I feel about a function that creates classes. Can we inherit from a base class instead?

cadence commented on pull request cadence/Carbon#24

2020-10-29 07:46:58 +00:00

Rich message rendering

The original idea here was that we'd have a predicate for things like whether the method can be displayed as a message group, whether it should show a timestamp, or whatever other things could affect the display based on the class. I haven't actually put this method to any use yet.

cadence commented on pull request cadence/Carbon#24

2020-10-29 07:46:58 +00:00

Rich message rendering

style: can we put spaces after // ?

cadence commented on pull request cadence/Carbon#24

2020-10-29 07:46:58 +00:00

Rich message rendering

Again here. I think a better way would be to have a base class like MembershipEvent, and then for each kind of membership we subclass it and only implement the canRender method on each.

cadence pushed to princess at cadence/Carbon

2020-10-29 04:32:18 +00:00

ff196a64bb Improve message sender rendering

a4c7f29ec9 Emacs files to gitignore

5bfe98bdf4 Stop scrollback at top of timeline

Compare 3 commits »

cadence pushed to princess at cadence/Carbon

2020-10-26 10:57:05 +00:00

f4b368ea3e Better message line breaking

cadence pushed to princess at cadence/Carbon

2020-10-26 10:36:44 +00:00

6da9f41519 Merge pull request 'Add scrollback' (#22) from scrollback into princess

df47c8a88a Style load more; fix message group order

c9dffc9d4a Wait for events to load before saving scroll position

6227f6fa84 Add scrollback

Compare 4 commits »

cadence merged pull request cadence/Carbon#22

2020-10-26 10:36:44 +00:00

Add scrollback

cadence pushed to scrollback at cadence/Carbon

2020-10-26 10:35:57 +00:00

df47c8a88a Style load more; fix message group order

cadence pushed to princess at cadence/Carbon

2020-10-26 09:33:52 +00:00

5ab182e615 Merge pull request 'Bundle with browserify' (#19) from browserify into princess

08a0990bc8 Add back jshint; format

51905ab3f2 add browserify

Compare 3 commits »

cadence merged pull request cadence/Carbon#19

2020-10-26 09:33:52 +00:00

Bundle with browserify

cadence pushed to browserify at cadence/Carbon

2020-10-26 09:31:39 +00:00

08a0990bc8 Add back jshint; format

cadence deleted branch fix/gitignore from cadence/Carbon

2020-10-23 11:46:15 +00:00

cadence pushed to princess at cadence/Carbon

2020-10-23 11:46:05 +00:00

d90be7a0d4 Merge pull request 'Add better .gitignore' (#17) from fix/gitignore into princess

79aa423ebb Merge branch 'princess' into fix/gitignore

6499cd4ff6 add better .gitignore

Compare 3 commits »

cadence merged pull request cadence/Carbon#17

2020-10-23 11:46:05 +00:00

Add better .gitignore

cadence pushed to princess at cadence/Carbon

2020-10-22 10:04:11 +00:00

2f5955b043 Be able to load past room state (no UI yet)

cadence pushed to princess at cadence/Carbon

2020-10-22 10:03:04 +00:00

36f204624f Refuse to send empty messages

cadence commented on issue cadence/Carbon#16

2020-10-22 09:02:44 +00:00

Just created empty room throws error on rooms and directs loading

If you see the events in the timeline, they're passed as timeline events, not state events. Probably nothing to worry about.

cadence closed issue cadence/Carbon#16

2020-10-22 09:02:04 +00:00

Just created empty room throws error on rooms and directs loading

cadence commented on issue cadence/Carbon#16

2020-10-22 07:59:22 +00:00

Just created empty room throws error on rooms and directs loading

Maybe fixed in e18c8c77aef6a5ac36b2a9c22daa8f3fb8efb7cb? Please try, you can use https://carbon.chat to find out.