Repositories
5
 Projects Packages Public activity Starred repositories
2
cadence commented on pull request cadence/out-of-your-element#63 2025-11-02 09:43:23 +00:00
feat/add-unlink-space-button

Just an initial eyeball. I haven't executed this code yet.

cadence commented on pull request cadence/out-of-your-element#63 2025-11-02 09:43:23 +00:00
feat/add-unlink-space-button

What is the purpose of this database operation?

cadence commented on pull request cadence/out-of-your-element#63 2025-11-02 09:43:23 +00:00
feat/add-unlink-space-button

You deleted the thing that checks that the user has Manage Server permissions and you didn't put it back.

cadence pushed to feat/add-unlink-space-button at Elliu/out-of-your-element 2025-11-02 09:31:21 +00:00
5f0ec3b2c8 Improve HTML to a state I'm happy with
cadence pushed to feat/add-unlink-space-button at Elliu/out-of-your-element 2025-11-02 07:51:44 +00:00
16309f26b3 add tests from /unlink-space endpoint
5aff6f9048 Add /api/unlink-space implementation
dfc61594f6 Extract /api/unlink code to its own function
3597a3b5ce Factorize some of the space link/unlink sanity checks
05d788e263 Add button to unlink a space
Compare 6 commits »
cadence pushed to main at cadence/out-of-your-element 2025-11-02 07:50:19 +00:00
d95a114377 Fix matrix api joinRoom() for remote rooms (#60)
cadence merged pull request cadence/out-of-your-element#60 2025-11-02 07:50:17 +00:00
Fix matrix api joinRoom() for remote rooms
cadence pushed to fix-remote-join at Elliu/out-of-your-element 2025-11-02 07:48:51 +00:00
a55d7a1632 Style match
cadence pushed to fix-remote-join at Elliu/out-of-your-element 2025-11-02 07:46:38 +00:00
789c7b0334 Style match
cadence pushed to main at cadence/out-of-your-element 2025-10-31 03:22:40 +00:00
255e166e8c Better message when remote emojis unavailable
cadence pushed to main at cadence/out-of-your-element 2025-10-23 12:09:24 +00:00
d4f4664c25 Fix retrying m->d message deletions
cadence pushed to main at cadence/out-of-your-element 2025-10-23 12:05:33 +00:00
b9a3a329ab Fix retrying m->d message deletions
cadence pushed to main at cadence/out-of-your-element 2025-10-12 18:17:27 +00:00
3de762d428 Fix stickers that don't provide content type
cadence pushed to main at cadence/out-of-your-element 2025-10-10 18:26:06 +00:00
cffd3c9f2e Fix converting discord channel links
cadence commented on pull request cadence/out-of-your-element#60 2025-10-07 19:24:01 +00:00
Fix matrix api joinRoom() for remote rooms

Status code 400 please.

cadence commented on pull request cadence/out-of-your-element#60 2025-10-07 19:24:01 +00:00
Fix matrix api joinRoom() for remote rooms

This is fine and doesn't need changing (apart from making the status code 400, please)

cadence commented on pull request cadence/out-of-your-element#60 2025-10-07 19:24:01 +00:00
Fix matrix api joinRoom() for remote rooms

When creating a new variable, it ought to be declared with let or const. Please use `const here.

cadence commented on pull request cadence/out-of-your-element#60 2025-10-07 19:24:01 +00:00
Fix matrix api joinRoom() for remote rooms

Please use server = mxid.match(/:(.*)/)?.[1] (see utils.js line 168) which is short enough that it can be used inline without needing to be extracted to a function. So please delete the function getHSOfUser and just do the operation inline where needed.

cadence commented on pull request cadence/out-of-your-element#60 2025-10-07 19:24:01 +00:00
Fix matrix api joinRoom() for remote rooms

Looks good. Please address the invididual comments (or ask me to do it for you). Then I can do a final coverage check and merge this. Thanks for your patience!

cadence commented on pull request cadence/out-of-your-element#60 2025-10-07 19:24:01 +00:00
Fix matrix api joinRoom() for remote rooms

This condition can't happen, because it's always possible to extract a via from the user who sent the invite. Remove the if statement and just always use the more detailed error message.