cadence/out-of-your-element
cadence/out-of-your-element
2
6
Fork 1
Code Issues 12 Pull requests Releases 17 Activity

d->m: Late-loaded embeds might not appear? #29

New issue
Closed
opened 2024-01-13 10:38:10 +00:00 by cadence · 2 comments
cadence commented 2024-01-13 10:38:10 +00:00
Owner
Copy link

If it's the first time an embed (URL preview) appears and Discord doesn't have it cached, Discord will take time to load the data, then send a MESSAGE_UPDATE for the original message to add the embed to it.

It seems like this doesn't work some or all of the time: https://matrix.to/#/!TqlyQmifxGUggEmdBN:cadence.moe/$O-Ra7iqqJG5jtT7Omxx26DCh8JzZk_888Ruhze4TgoU?via=cadence.moe&via=matrix.org&via=conduit.rory.gay

I know that this MESSAGE_UPDATE doesn't include many essential properties, so the first thing to do is make sure it isn't being excluded due to a missing properties guard.

If it's the first time an embed (URL preview) appears and Discord doesn't have it cached, Discord will take time to load the data, then send a MESSAGE_UPDATE for the original message to add the embed to it. It seems like this doesn't work some or all of the time: https://matrix.to/#/!TqlyQmifxGUggEmdBN:cadence.moe/$O-Ra7iqqJG5jtT7Omxx26DCh8JzZk_888Ruhze4TgoU?via=cadence.moe&via=matrix.org&via=conduit.rory.gay I know that this MESSAGE_UPDATE doesn't include many essential properties, so the first thing to do is make sure it isn't being excluded due to a missing properties guard.
cadence changed title from d->m: Embeds might not appear when the message is updated? to d->m: Late-loaded embeds might not appear? 2024-01-13 10:38:31 +00:00
cadence commented 2024-03-17 02:35:25 +00:00
Author
Owner
Copy link

This was fixed in d01c888d02 and 23d85547f3

This was fixed in d01c888d02180a30ee8313122ac2f5744dd356ad and 23d85547f34b7998a4eddeebb3051aff7de1125c
cadence commented 2024-03-19 09:54:01 +00:00
Author
Owner
Copy link

This had extra code added in c615ea1e61 and bce3d0f2c9 to reflect back generated embeds for messages sent by Matrix users.

This had extra code added in c615ea1e6162a1f193f29e52d277d5a01f9fecdd and bce3d0f2c9b622a9aa9d564ee69a5c833e70d51d to reflect back generated embeds for messages sent by Matrix users.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
ex/webhook-profile
alt-host
v3.0-beta5
v3.0-beta4
v3.0-beta3
v3.0-beta2
v3.0-beta1
v2.3
v2.2
v2.1
v2.0
v1.5.1
v1.5
v1.4
v1.3
v1.2
v1.1.1
v1.1
v1.0
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: cadence/out-of-your-element#29
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?