cadence/out-of-your-element
cadence
/
out-of-your-element
2
6
Fork 1
Code Issues 13 Pull Requests Releases 10 Activity

Editing a Matrix message to be shorter will make OOYE delete it from Matrix #18

New Issue
Closed
opened 2023-12-03 04:03:08 +00:00 by cadence · 2 comments
cadence commented 2023-12-03 04:03:08 +00:00
Owner
Copy Link
  1. On Matrix, send a message longer than 2000 characters
  2. Edit it to be shorter
  3. OOYE deletes the second message from Discord-side (intended)
  4. OOYE notices a deletion and deletes the message from Matrix-side (oops)
1. On Matrix, send a message longer than 2000 characters 2. Edit it to be shorter 3. OOYE deletes the second message from Discord-side (intended) 4. OOYE notices a deletion and deletes the message from Matrix-side (oops)
cadence commented 2024-01-10 02:45:04 +00:00
Author
Owner
Copy Link

To fix this, I think I just need to remove the relationship between the event and message in the database before deleting it from Discord-side. When the relationship is gone, if OOYE notices a deletion for an unknown message, it won't do anything.

Will check in a fix and test it later.

To fix this, I think I just need to remove the relationship between the event and message in the database before deleting it from Discord-side. When the relationship is gone, if OOYE notices a deletion for an unknown message, it won't do anything. Will check in a fix and test it later.
cadence commented 2024-01-10 09:56:39 +00:00
Author
Owner
Copy Link

Manual testing looks good

Manual testing looks good
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
alt-host
v2.1
v2.0
v1.5.1
v1.5
v1.4
v1.3
v1.2
v1.1.1
v1.1
v1.0
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cadence/out-of-your-element#18
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?