cadence/out-of-your-element
cadence/out-of-your-element
2
6
Fork 1
Code Issues 12 Pull requests Releases 17 Activity

remove redactions from database in edit flow

Browse source
This commit is contained in:
Cadence Ember 2023-08-18 01:23:53 +12:00
parent 2d14e84312
commit 6246dc3a7f
2 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
d2m/actions/edit-message.js
View file

@ -14,7 +14,8 @@ const api = sync.require("../../matrix/api")
async function editMessage(message, guild) { async function editMessage(message, guild) {
console.log(`*** applying edit for message ${message.id} in channel ${message.channel_id}`) console.log(`*** applying edit for message ${message.id} in channel ${message.channel_id}`)
const {roomID, eventsToRedact, eventsToReplace, eventsToSend, senderMxid} = await editToChanges.editToChanges(message, guild, api) const {roomID, eventsToRedact, eventsToReplace, eventsToSend, senderMxid} = await editToChanges.editToChanges(message, guild, api)
console.log("making these changes:", {eventsToRedact, eventsToReplace, eventsToSend}) console.log("making these changes:")
console.dir({eventsToRedact, eventsToReplace, eventsToSend}, {depth: null})
// 1. Replace all the things. // 1. Replace all the things.
for (const {oldID, newContent} of eventsToReplace) { for (const {oldID, newContent} of eventsToReplace) {
@ -34,7 +35,9 @@ async function editMessage(message, guild) {
// Not redacting as the last action because the last action is likely to be shown in the room preview in clients, and we don't want it to look like somebody actually deleted a message. // Not redacting as the last action because the last action is likely to be shown in the room preview in clients, and we don't want it to look like somebody actually deleted a message.
for (const eventID of eventsToRedact) { for (const eventID of eventsToRedact) {
await api.redactEvent(roomID, eventID, senderMxid) await api.redactEvent(roomID, eventID, senderMxid)
// TODO: I should almost certainly remove the redacted event from our database now, shouldn't I? I mean, it's literally not there any more... you can't do anything else with it... // TODO: Reconsider whether it's the right thing to do to delete it from our database? I mean, it's literally not there any more... you can't do anything else with it...
// and you definitely want to mark it in *some* way to prevent duplicate redactions...
db.prepare("DELETE from event_message WHERE event_id = ?").run(eventID)
// TODO: If I just redacted part = 0, I should update one of the other events to make it the new part = 0, right? // TODO: If I just redacted part = 0, I should update one of the other events to make it the new part = 0, right?
// TODO: Consider whether this code could be reused between edited messages and deleted messages. // TODO: Consider whether this code could be reused between edited messages and deleted messages.
} }

BIN
scripts/events.db
View file

Binary file not shown.