cadence/breezewiki
2
4
Fork 4
Code Issues Pull requests 1 Releases Wiki Activity

Loosen criteria for noscript images #9

Closed
blankie wants to merge 1 commit from blankie/breezewiki:noscript-a-img into main
pull from: blankie/breezewiki:noscript-a-img
merge into: cadence:main
Conversation 2 Commits 1 Files changed 1 +8 -3
1 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/page-wiki.rkt
View file

@ -57,7 +57,12 @@
(data-src "https://static.wikia.nocookie.net/nice-image-thumbnail.png") (data-src "https://static.wikia.nocookie.net/nice-image-thumbnail.png")
(class "thumbimage lazyload")))) (class "thumbimage lazyload"))))
(noscript (noscript
(a (@ (href "https://static.wikia.nocookie.net/nice-image.png") (class "image")) (a (@ (href "https://static.wikia.nocookie.net/nice-image.png") (title "a nice image") (three-attribs))
(img (@ (src "https://static.wikia.nocookie.net/nice-image-thumbnail.png")
(data-src "https://static.wikia.nocookie.net/nice-image-thumbnail.png")
(class "thumbimage")))))
(noscript
(a (@ (href "https://static.wikia.nocookie.net/nice-image.png"))
(img (@ (src "https://static.wikia.nocookie.net/nice-image-thumbnail.png") (img (@ (src "https://static.wikia.nocookie.net/nice-image-thumbnail.png")
(data-src "https://static.wikia.nocookie.net/nice-image-thumbnail.png") (data-src "https://static.wikia.nocookie.net/nice-image-thumbnail.png")
(class "thumbimage"))))) (class "thumbimage")))))
@ -122,8 +127,8 @@
; remove noscript versions of images because they are likely lower quality than the script versions ; remove noscript versions of images because they are likely lower quality than the script versions
[(and (eq? element-type 'noscript) [(and (eq? element-type 'noscript)
(match children (match children
; either the noscript has a.image as a first child... ; either the noscript has an a, with attributes and an img as a first child, as a first child...
[(list (list 'a (list '@ a-att ...) _)) (has-class? "image" a-att)] [(list (list 'a (list '@ _ ...) (list 'img _))) #t]
; or the noscript has img as a first child ; or the noscript has img as a first child
[(list (list 'img _)) #t] [(list (list 'img _)) #t]
[_ #f])) [_ #f]))