cadence/Carbon
3
9
Fork 1
Code Issues 14 Pull requests 1 Releases Wiki Activity

Rich message rendering #24

Merged
cadence merged 28 commits from rich-messages into princess 2020-11-07 10:46:48 +00:00
Conversation 3 Commits 28 Files changed 17 +1 -1
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 66ecf44048 - Show all commits

2
src/js/events/membership.js
View file

@ -6,7 +6,7 @@ function createMembershipEvent(membership, message) {
return simpleEvent((e) => e.type == "m.room.member" && e.content.membership === membership, message) return simpleEvent((e) => e.type == "m.room.member" && e.content.membership === membership, message)
bad marked this conversation as resolved Outdated
cadence commented 2020-10-29 07:45:04 +00:00
Outdated
Review
Copy link

Again here. I think a better way would be to have a base class like MembershipEvent, and then for each kind of membership we subclass it and only implement the canRender method on each.

Again here. I think a better way would be to have a base class like MembershipEvent, and then for each kind of membership we subclass it and only implement the canRender method on each.
} }
const JoinedEvent = createMembershipEvent("join", (e) => {console.log(e); return "joined the room"}) const JoinedEvent = createMembershipEvent("join", (e) => "joined the room")
const InvitedEvent = createMembershipEvent("invite", (e) => `invited ${e.content.displayname} the room`) const InvitedEvent = createMembershipEvent("invite", (e) => `invited ${e.content.displayname} the room`)
const LeaveEvent = createMembershipEvent("leave", () => "left the room") const LeaveEvent = createMembershipEvent("leave", () => "left the room")