Sending empty messages #15

New Issue

Closed

opened 2020-10-22 07:15:07 +00:00 by koloml · 4 comments

koloml commented

2020-10-22 07:15:07 +00:00

If you try to press Enter on empty message input, Carbon will send an empty message, like this one:

{
  "type": "m.room.message",
  "sender": "@koloml:thecore.city",
  "content": {
    "msgtype": "m.text",
    "body": "",
    "chat.carbon.message.pending_id": "pending$1603350677789"
  },
  "origin_server_ts": 1603350679477,
  "unsigned": {
    "age": 19749
  },
  "event_id": "$R7nZZ5YGVDGX-12pSD2RmX7649-McZ9kEjmsz3HwE-Y",
  "room_id": "!GfXFsxiwTgNUhUHWms:sunbutt.faith"
}

If you try to press `Enter` on empty message input, Carbon will send an empty message, like this one: ```json { "type": "m.room.message", "sender": "@koloml:thecore.city", "content": { "msgtype": "m.text", "body": "", "chat.carbon.message.pending_id": "pending$1603350677789" }, "origin_server_ts": 1603350679477, "unsigned": { "age": 19749 }, "event_id": "$R7nZZ5YGVDGX-12pSD2RmX7649-McZ9kEjmsz3HwE-Y", "room_id": "!GfXFsxiwTgNUhUHWms:sunbutt.faith" } ```

cadence commented

2020-10-22 07:16:18 +00:00

Owner

How do you think we should check for if a message is empty? If body.trim().length is 0 ?

How do you think we should check for if a message is empty? If `body.trim().length` is `0` ?

koloml commented

2020-10-22 07:20:44 +00:00

Author

Yup. We want to refuse to send messages with such empty spaces without any other symbols. Also, maybe it's better to always trim message body before checking length. Just because browser anyway ignore additional spaces.