From 157bb9fc473be3aa6e19c7c6229c6ffb072800ee Mon Sep 17 00:00:00 2001 From: Bad Date: Sun, 1 Nov 2020 17:33:27 +0100 Subject: [PATCH 1/4] style fixes --- src/sass/tippy.sass | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/sass/tippy.sass b/src/sass/tippy.sass index f2643f3..bc97399 100644 --- a/src/sass/tippy.sass +++ b/src/sass/tippy.sass @@ -3,7 +3,8 @@ @use "./colors.sass" as c .tippy-box[data-theme~="carbon"] - background-color: c.$milder - border: 2px solid c.$divider - .tippy-svg-arrow - fill: c.$milder + background-color: c.$milder + border: 2px solid c.$divider + + .tippy-svg-arrow + fill: c.$milder From d8343f59760b48cd61bf535b25c58facd8fe4bc1 Mon Sep 17 00:00:00 2001 From: Bad Date: Sun, 1 Nov 2020 17:35:10 +0100 Subject: [PATCH 2/4] Change homserver-question into a class --- src/js/login.js | 2 +- src/login.pug | 2 +- src/sass/login.sass | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/js/login.js b/src/js/login.js index a7457da..ba260ef 100644 --- a/src/js/login.js +++ b/src/js/login.js @@ -54,7 +54,7 @@ class Homeserver extends ElemJS { constructor() { super(q("#homeserver")); - this.tippy = tippy.default(q("#homeserver-question"), { + this.tippy = tippy.default(q(".homeserver-question"), { content: q("#homeserver-popup-template").innerHTML, allowHTML: true, interactive: true, diff --git a/src/login.pug b/src/login.pug index e8408eb..108d989 100644 --- a/src/login.pug +++ b/src/login.pug @@ -24,7 +24,7 @@ html .form-input-container .homeserver-label label(for="homeserver") Homeserver - span#homeserver-question (What's this?) + span.homeserver-question (What's this?) input(type="text" name="homeserver" placeholder="matrix.org")#homeserver #feedback diff --git a/src/sass/login.sass b/src/sass/login.sass index d9d57cc..8482819 100644 --- a/src/sass/login.sass +++ b/src/sass/login.sass @@ -44,7 +44,7 @@ .form-error color: red -#homeserver-question +.homeserver-question font-size: 0.6em padding-left: 0.2em From fc5dbe93e72b51366922eb10d3ae50f74175d890 Mon Sep 17 00:00:00 2001 From: Bad Date: Sun, 1 Nov 2020 17:55:57 +0100 Subject: [PATCH 3/4] Make homeserver explanatoin accessible --- src/js/login.js | 2 +- src/login.pug | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/js/login.js b/src/js/login.js index ba260ef..216b12d 100644 --- a/src/js/login.js +++ b/src/js/login.js @@ -59,7 +59,7 @@ class Homeserver extends ElemJS { allowHTML: true, interactive: true, interactiveBorder: 10, - trigger: "mouseenter", + trigger: "focus mouseenter", theme: "carbon", arrow: tippy.roundArrow, }) diff --git a/src/login.pug b/src/login.pug index 108d989..918e157 100644 --- a/src/login.pug +++ b/src/login.pug @@ -24,7 +24,7 @@ html .form-input-container .homeserver-label label(for="homeserver") Homeserver - span.homeserver-question (What's this?) + span.homeserver-question(tabindex=0) (What's this?) input(type="text" name="homeserver" placeholder="matrix.org")#homeserver #feedback From 48c6ae7efbea290686787eb9377259b68569a99c Mon Sep 17 00:00:00 2001 From: Bad Date: Sun, 1 Nov 2020 17:57:19 +0100 Subject: [PATCH 4/4] Increase the size of the homeserver explanation --- src/sass/login.sass | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/sass/login.sass b/src/sass/login.sass index 8482819..d8385dd 100644 --- a/src/sass/login.sass +++ b/src/sass/login.sass @@ -45,8 +45,7 @@ color: red .homeserver-question - font-size: 0.6em - padding-left: 0.2em + font-size: 0.8em .homeserver-label display: flex