From 1ab0d4fa31b44b5889df2b2097bf30495629cdf3 Mon Sep 17 00:00:00 2001 From: Emanuele Antonelli Date: Mon, 12 Mar 2018 14:11:13 +0100 Subject: [PATCH] fix undefined vars in server - misplaced conditions (#2) --- server.js | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/server.js b/server.js index 5ea094f..867b35c 100644 --- a/server.js +++ b/server.js @@ -194,14 +194,14 @@ router.post('/find-one-update', function(req, res, next) { var p = new Person(req.body); p.save(function(err, pers) { if(err) { return next(err) } - if(!data) { - console.log('Missing `done()` argument'); - return next({message: 'Missing callback argument'}); - } try { update(pers.name, function(err, data) { clearTimeout(t); if(err) { return next(err) } + if (!data) { + console.log('Missing `done()` argument'); + return next({ message: 'Missing callback argument' }); + } res.json(data); p.remove(); }); @@ -283,14 +283,14 @@ router.post('/query-tools', function(req, res, next) { if(err) if(err) { return next(err) } Person.create(req.body, function(err, pers) { if(err) { return next(err) } - if(!data) { - console.log('Missing `done()` argument'); - return next({message: 'Missing callback argument'}); - } try { chain(function(err, data) { clearTimeout(t); if(err) { return next(err) } + if (!data) { + console.log('Missing `done()` argument'); + return next({ message: 'Missing callback argument' }); + } res.json(data); }); } catch (e) {