From ba9443fc08377d613c7a0856d29771a7684a7ff8 Mon Sep 17 00:00:00 2001 From: Breval Ferrari Date: Wed, 19 Mar 2025 01:16:08 -0400 Subject: [PATCH] clippy --- bingus/Cargo.toml | 2 +- bingus/src/snd/simphonia.rs | 12 +++++------- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/bingus/Cargo.toml b/bingus/Cargo.toml index 41573b5..e56793a 100644 --- a/bingus/Cargo.toml +++ b/bingus/Cargo.toml @@ -20,5 +20,5 @@ strum = { version = "0.26", features = ["derive"] } derive_wrapper = "0.1" symphonia = { version = "0.5", features = ["all"] } -[dev_dependencies] +[dev-dependencies] project-root = "0.2.2" diff --git a/bingus/src/snd/simphonia.rs b/bingus/src/snd/simphonia.rs index 52a1b9c..c1ab65e 100644 --- a/bingus/src/snd/simphonia.rs +++ b/bingus/src/snd/simphonia.rs @@ -10,7 +10,6 @@ use symphonia::{ audio::Signal, codecs::{Decoder, CODEC_TYPE_NULL}, conv::FromSample, - errors::Error, formats::FormatReader, io::MediaSourceStream, probe::Hint, @@ -20,7 +19,7 @@ use symphonia::{ }; use thiserror::Error; -use crate::{IntoDataBytes, TryFromDataBytes}; +use crate::IntoDataBytes; use super::{RawSamples, Sample}; @@ -58,11 +57,10 @@ impl Audio { let mss = MediaSourceStream::new(Box::new(mediasource), Default::default()); let reader = probe .format( - &Hint::new().with_extension( + Hint::new().with_extension( path.as_ref() .extension() - .map(|os_str| os_str.to_str()) - .flatten() + .and_then(|os_str| os_str.to_str()) .unwrap_or("mp3"), ), mss, @@ -71,7 +69,7 @@ impl Audio { )? .format; let decoder = registry.make( - &reader + reader .tracks() .iter() .find(|t| t.codec_params.codec != CODEC_TYPE_NULL) @@ -148,7 +146,7 @@ where .flat_map(|ch| audio_buffer .chan(ch) .iter() - .map(|s| S::from_sample(s.clone())) + .map(|s| S::from_sample(*s)) .collect::>()) .collect::>() )