Remove noscript versions of images

Script versions are likely better quality, and BreezeWiki makes them
viewable without requiring scripts anyway.
This commit is contained in:
Cadence Ember 2022-10-10 22:52:35 +13:00
parent 58d6a652d8
commit 7a8a1cd40f
Signed by untrusted user: cadence
GPG key ID: BC1C2C61CF521B17

View file

@ -51,6 +51,17 @@
(p "Another page link: " (p "Another page link: "
(a (@ (data-test-wikilink) (href "https://test.fandom.com/wiki/Another_Page") (title "Another Page")) (a (@ (data-test-wikilink) (href "https://test.fandom.com/wiki/Another_Page") (title "Another Page"))
"Another Page")))) "Another Page"))))
(figure (@ (class "thumb tnone"))
(a (@ (href "https://static.wikia.nocookie.net/nice-image.png") (class "image"))
(img (@ (src "data:image/gif;base64,R0lGODlhAQABAIABAAAAAP///yH5BAEAAAEALAAAAAABAAEAQAICTAEAOw%3D%3D")
(data-src "https://static.wikia.nocookie.net/nice-image-thumbnail.png")
(class "thumbimage lazyload"))))
(noscript
(a (@ (href "https://static.wikia.nocookie.net/nice-image.png") (class "image"))
(img (@ (src "https://static.wikia.nocookie.net/nice-image-thumbnail.png")
(data-src "https://static.wikia.nocookie.net/nice-image-thumbnail.png")
(class "thumbimage")))))
(figcaption "Test figure!"))
(iframe (@ (src "https://example.com/iframe-src"))))))) (iframe (@ (src "https://example.com/iframe-src")))))))
(define (preprocess-html-wiki html) (define (preprocess-html-wiki html)
@ -108,6 +119,15 @@
`(a `(a
((class "iframe-alternative") (href ,src)) ((class "iframe-alternative") (href ,src))
(,(format "Embedded media: ~a" src)))] (,(format "Embedded media: ~a" src)))]
; remove noscript versions of images because they are likely lower quality than the script versions
[(and (eq? element-type 'noscript)
(match children
; either the noscript has a.image as a first child...
[(list (list 'a (list '@ a-att ...) _)) (has-class? "image" a-att)]
; or the noscript has img as a first child
[(list (list 'img _)) #t]
[_ #f]))
return-no-element]
[#t [#t
(list element-type (list element-type
;; attributes ;; attributes
@ -233,7 +253,9 @@
((query-selector ((query-selector
(λ (t a c) (and (eq? t 'a) (has-class? "image-thumbnail" a))) (λ (t a c) (and (eq? t 'a) (has-class? "image-thumbnail" a)))
transformed)))) transformed))))
"/proxy?dest=https%3A%2F%2Fstatic.wikia.nocookie.net%2Fnice-image.png")) "/proxy?dest=https%3A%2F%2Fstatic.wikia.nocookie.net%2Fnice-image.png")
; check that noscript images are removed
(check-equal? ((query-selector (λ (t a c) (eq? t 'noscript)) transformed)) #f))
(define (page-wiki req) (define (page-wiki req)
(define wikiname (path/param-path (first (url-path (request-uri req))))) (define wikiname (path/param-path (first (url-path (request-uri req)))))