archy-slstatus/components/hostname.c

/* See LICENSE file for copyright and license details. */
#include <errno.h>
#include <stdio.h>
#include <string.h>
#include <unistd.h>

#include "../util.h"

const char *
hostname(void)
{
	if (gethostname(buf, sizeof(buf)) < 0) {
		warn("gethostbyname:");
		return NULL;
	}

	return buf;
}
Added LICENSE statements to all source files 2017-09-17 15:45:03 +00:00			`/* See LICENSE file for copyright and license details. */`
Format error messages properly Make use of strerror(errno) and format all errors equally: function ['parameters']: error message 2018-03-28 17:46:27 +00:00			`#include <errno.h>`
Get rid of err.h as it is not portable Replace warn() and warnx() with fprintf() and add <stdio.h> where necessary. 2018-03-28 16:26:56 +00:00			`#include <stdio.h>`
Format error messages properly Make use of strerror(errno) and format all errors equally: function ['parameters']: error message 2018-03-28 17:46:27 +00:00			`#include <string.h>`
Split into multiple files For multiple reasons the program is now split: - Make future porting to OpenBSD easier - Assign header includes to individiual functions - Make future program extensions easier - Recompile only changed parts 2017-09-17 14:18:17 +00:00			`#include <unistd.h>`

Move components into dedicated subdirectory This brings us a lot more tidiness. 2017-09-24 13:33:01 +00:00			`#include "../util.h"`
Split into multiple files For multiple reasons the program is now split: - Make future porting to OpenBSD easier - Assign header includes to individiual functions - Make future program extensions easier - Recompile only changed parts 2017-09-17 14:18:17 +00:00
			`const char *`
			`hostname(void)`
			`{`
Fix coding style - Use block for single statement ifs - Keep lines to reasonable length (current debate as to reasonable) - When functions return -1 for error test against 0 not -1 - Do not indent cases another level - Do not test against NULL and 0 explicitly - Use tabs for indentation, use spaces for alignment 2018-05-06 20:28:56 +00:00			`if (gethostname(buf, sizeof(buf)) < 0) {`
Add warn() and die() Given slstatus is a tool that runs in the background, most likely run from .xinitrc, it's important to prepend the name of the tool to error messages so it becomes clear where the error is coming from. To make this much more consistent, this commit adds warn() and die() utility functions consistent with other suckless projects and adapts all calls to fprintf(stderr, *) to the warn() and die() functions, greatly increasing the readability of the code. 2018-05-18 08:59:05 +00:00			`warn("gethostbyname:");`
Split into multiple files For multiple reasons the program is now split: - Make future porting to OpenBSD easier - Assign header includes to individiual functions - Make future program extensions easier - Recompile only changed parts 2017-09-17 14:18:17 +00:00			`return NULL;`
			`}`

			`return buf;`
			`}`