anas-elgarhy/cmus-notify
1
0
Fork 0
Code Issues 1 Pull requests 1 Projects Releases 1 Packages Wiki Activity

Refactor TrackCover set_notification_image to use String for external path

Browse source
This commit is contained in:
Anas Elgarhy 2023-02-23 13:51:06 +02:00
parent cdc5085506
commit 8c4a2a5501
No known key found for this signature in database
GPG key ID: 0501802A1D496528
1 changed files with 7 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/lib.rs
View file

@ -121,7 +121,7 @@ pub enum TrackCover {
Embedded(image::DynamicImage), Embedded(image::DynamicImage),
/// The cover is an external file. /// The cover is an external file.
/// The `String` contains the absolute path of the external file. /// The `String` contains the absolute path of the external file.
External(image::DynamicImage), External(String),
/// The track does not have a cover. /// The track does not have a cover.
None, None,
} }
@ -130,17 +130,20 @@ impl TrackCover {
pub fn set_notification_image(&self, notification: &mut notify_rust::Notification) { pub fn set_notification_image(&self, notification: &mut notify_rust::Notification) {
use TrackCover::*; use TrackCover::*;
match self { match self {
Embedded(cover) | External(cover) => { Embedded(cover) => {
#[cfg(feature = "debug")] #[cfg(feature = "debug")]
debug!("Setting the cover as the notification image."); debug!("Setting the cover as the notification image.");
let Ok(image) = notify_rust::Image::try_from(cover.clone()) else { return; }; let Ok(image) = notify_rust::Image::try_from(cover.clone()) else { return; };
notification.image_data(image); notification.image_data(image);
} }
External(path) => {
#[cfg(feature = "debug")]
debug!("Setting the cover as the notification image.");
notification.image_path(path);
}
None => { None => {
#[cfg(feature = "debug")] #[cfg(feature = "debug")]
debug!("The track does not have a cover."); debug!("The track does not have a cover.");
// reset the notification image
notification.image_path("");
} }
} }
} }
@ -188,11 +191,6 @@ pub fn track_cover(
) { ) {
#[cfg(feature = "debug")] #[cfg(feature = "debug")]
info!("Found the external cover \"{cover}\"."); info!("Found the external cover \"{cover}\".");
let Ok(cover) = image::open(cover) else {
#[cfg(feature = "debug")]
info!("Could not open the external cover.");
return TrackCover::None;
};
return TrackCover::External(cover); return TrackCover::External(cover);
} }
} }