anas-elgarhy/aarty
1
0
Fork 0
Code Issues 1 Pull requests 2 Projects Releases 27 Packages Wiki Activity

Feature: width argument to calculate scale from number of available columns #6

Merged
giulio-Joshi merged 3 commits from columns_arg into master 2022-10-26 19:36:21 +00:00
Conversation 3 Commits 3 Files changed 3 +64 -2
giulio-Joshi commented 2022-10-25 19:16:52 +00:00 (Migrated from github.com)
Copy link

Hello, its me again 😃

I'm using your converter and found myself in this situation: I wanted to aartyze a bunch of pics from different size, all to an ascii file the same width.
This feature come out naturally and gave the occasion of testing a small part of the code.

Do you think this could help you?

Hello, its me again :smiley: I'm using your converter and found myself in this situation: I wanted to `aartyze` a bunch of pics from different size, all to an ascii file the same width. This feature come out naturally and gave the occasion of testing a small part of the code. Do you think this could help you?
❤️ 1
anas-elgarhy commented 2022-10-26 15:58:28 +00:00 (Migrated from github.com)
Copy link

Nice feature @giulio-Joshi, I Think it will be useful ❤️

Nice feature @giulio-Joshi, I Think it will be useful ❤️
🚀 1
anas-elgarhy commented 2022-10-26 16:01:35 +00:00 (Migrated from github.com)
Copy link

I'm glad you liked the tool, And thanks to you for tests

I'm glad you liked the tool, And thanks to you for tests
anas-elgarhy (Migrated from github.com) requested changes 2022-10-26 16:26:16 +00:00
README.md
@ -105,6 +105,9 @@ Options:
[default: 4]
-w, --width <WIDTH>
anas-elgarhy (Migrated from github.com) commented 2022-10-26 16:25:48 +00:00
Copy link

Please copy this from the aarty --help output to save the consistency

Please copy this from the `aarty --help` output to save the consistency
src/args.rs
anas-elgarhy (Migrated from github.com) commented 2022-10-26 16:11:13 +00:00
Copy link

Can you make this comment a document comment(///) instead of a normal comment, because the clap will be use it in the help message that appears when you run aarty --help

Can you make this comment a document comment(`///`) instead of a normal comment, because the `clap` will be use it in the help message that appears when you run `aarty --help`
src/ascii_processor.rs
@ -63,0 +89,4 @@
output_method: OutputMethod::Stdout,
image: "".into(),
characters: "".into(),
scale: 4,
anas-elgarhy (Migrated from github.com) commented 2022-10-26 16:20:34 +00:00
Copy link

You can make this method as inline method using the #[inline] suggests, This will can provide small but easy speed win.
https://nnethercote.github.io/perf-book/inlining.html

You can make this method as inline method using the `#[inline]` suggests, This will can provide small but easy speed win. https://nnethercote.github.io/perf-book/inlining.html
anas-elgarhy (Migrated from github.com) requested changes 2022-10-26 16:29:42 +00:00
anas-elgarhy (Migrated from github.com) left a comment
Copy link

Nice addition thanks, but there are some minor tweaks

Nice addition thanks, but there are some minor tweaks
giulio-Joshi (Migrated from github.com) reviewed 2022-10-26 17:55:27 +00:00
src/ascii_processor.rs
@ -63,0 +89,4 @@
output_method: OutputMethod::Stdout,
image: "".into(),
characters: "".into(),
scale: 4,
giulio-Joshi (Migrated from github.com) commented 2022-10-26 17:55:27 +00:00
Copy link

No problem, even if actually is called just once per run.

Could gain more performance if we read the image from a file, or from stdin (for better bash integration).

No problem, even if actually is called just once per run. Could gain more performance if we read the image from a file, or from `stdin` (for better bash integration).
giulio-Joshi commented 2022-10-26 17:55:46 +00:00 (Migrated from github.com)
Copy link

Yes of course, changes incoming.

Yes of course, changes incoming.
anas-elgarhy (Migrated from github.com) reviewed 2022-10-26 19:30:01 +00:00
src/ascii_processor.rs
@ -63,0 +89,4 @@
output_method: OutputMethod::Stdout,
image: "".into(),
characters: "".into(),
scale: 4,
anas-elgarhy (Migrated from github.com) commented 2022-10-26 19:30:01 +00:00
Copy link

I understand reading the image from a file, but what you mean with reading it from stdin?

I understand reading the image from a file, but what you mean with reading it from stdin?
anas-elgarhy (Migrated from github.com) approved these changes 2022-10-26 19:30:34 +00:00
giulio-Joshi (Migrated from github.com) reviewed 2022-10-26 19:48:28 +00:00
src/ascii_processor.rs
@ -63,0 +89,4 @@
output_method: OutputMethod::Stdout,
image: "".into(),
characters: "".into(),
scale: 4,
giulio-Joshi (Migrated from github.com) commented 2022-10-26 19:48:27 +00:00
Copy link

That would mean like how the -@ options works for zip program:

ls *.jpg | zip image_gallery.zip -@

All *.jpg files get streamed to zip and each one gets added to image_gallery.zip
But that would mean changing some of the program parameters.

That would mean like how the `-@` options works for `zip` program: ```bash ls *.jpg | zip image_gallery.zip -@ ``` All `*.jpg` files get streamed to `zip` and each one gets added to `image_gallery.zip` But that would mean changing some of the program parameters.
Sign in to join this conversation.
Reviewers
No reviewers
anas-elgarhy
Labels
Clear labels   
bug

Something isn't working

  
dependency tracking

   
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
hacktoberfest-accepted

   
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
major version

Automatically create a new major version tag after PR is merged

  
merge when passing

Merge the PR automatically once all status checks have passed

  
minor version

Automatically create a new minor version tag after PR is merged

  
need to testing

   
patch version

Automatically create a new patch version tag after PR is merged

  
question

Further information is requested

  
size/S

   
size/XS

   
wontfix

This will not be worked on

No labels
bug
dependency tracking
documentation
duplicate
enhancement
good first issue
hacktoberfest-accepted
help wanted
invalid
major version
merge when passing
minor version
need to testing
patch version
question
size/S
size/XS
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: anas-elgarhy/aarty#6
No description provided.
Delete branch "columns_arg"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?