Use `std::io::BufWriter` to achieve more flexibility #4

New issue

Closed

opened 2022-10-10 20:26:54 +00:00 by giulio-Joshi · 2 comments

giulio-Joshi commented

2022-10-10 20:26:54 +00:00

(Migrated from github.com)

Hello everyone!

I found your awesome project in the Hacktoberfest Discord, I hope my contribution can be of help.

I'm unsure in which direction the project can be expanded, so I attempted at making it more flexible in general: using a BufWriter to apply Inversion of Control on the generate_ascii function.

You can check the code on my branch:
https://github.com/giulio-Joshi/aarty/tree/bufferedOutput

Before barging in with a PR directly, I opted for asking some feedback about it.

Thanks a lot for your time 👍🏻

Hello everyone! I found your awesome project in the Hacktoberfest Discord, I hope my contribution can be of help. I'm unsure in which direction the project can be expanded, so I attempted at making it more flexible in general: using a `BufWriter` to apply Inversion of Control on the `generate_ascii` function. You can check the code on my branch: https://github.com/giulio-Joshi/aarty/tree/bufferedOutput Before barging in with a PR directly, I opted for asking some feedback about it. Thanks a lot for your time 👍🏻

❤️ 1

anas-elgarhy commented

2022-10-10 21:33:58 +00:00

(Migrated from github.com)

I liked your edits, and it faster than original method that's I use

anas-elgarhy commented

2022-10-10 21:35:36 +00:00

(Migrated from github.com)

I have learned new ways to think from you, thanks

❤️ 1