From 8ccef3b11092e39994b407915b96dd41b67ba11a Mon Sep 17 00:00:00 2001 From: Andry Yosua Date: Thu, 14 Sep 2023 04:54:56 +0700 Subject: [PATCH] looks simpler and more self-explaining fix suggested on https://github.com/TeamPiped/Piped/pull/2937#discussion_r1325072807 --- src/components/VideoPlayer.vue | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/src/components/VideoPlayer.vue b/src/components/VideoPlayer.vue index 48cdf0b8..94063864 100644 --- a/src/components/VideoPlayer.vue +++ b/src/components/VideoPlayer.vue @@ -595,17 +595,15 @@ export default { const autoDisplayCaptions = this.getPreferenceBoolean("autoDisplayCaptions", false); this.$player.setTextTrackVisibility(autoDisplayCaptions); - (() => { - const prefSubtitles = this.getPreferenceString("subtitles", ""); - if (prefSubtitles === "") return; - + const prefSubtitles = this.getPreferenceString("subtitles", ""); + if (prefSubtitles !== "") { const textTracks = this.$player.getTextTracks(); const subtitleIdx = textTracks.findIndex(textTrack => textTrack.language == prefSubtitles); - if (subtitleIdx == -1) return; - - this.$player.setTextTrackVisibility(true); - this.$player.selectTextTrack(textTracks[subtitleIdx]); - })(); + if (subtitleIdx != -1) { + this.$player.setTextTrackVisibility(true); + this.$player.selectTextTrack(textTracks[subtitleIdx]); + } + } }) .catch(e => { console.error(e);