TeamPiped-mirror/Piped
1
0
Fork 0
mirror of https://github.com/TeamPiped/Piped.git synced 2024-08-14 23:57:27 +00:00
Code Issues Projects Releases Packages Wiki Activity

Don't show audio language option if language is undetermined (#2937)

Browse source 
* Don't show audio language option if language is undetermined

as a viewer
i want simple option
so i
  - don't need to see unnecessary option
  - have more simple option
by not showing audio language option if language is undetermined

fix https://github.com/TeamPiped/Piped/issues/1761

* looks simpler and more self-explaining
This commit is contained in:
Andry Yosua 2023-09-14 13:53:48 +07:00 committed by GitHub
parent 5b4fb38c85
commit 859908cb1f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
src/components/VideoPlayer.vue
View file

@ -472,14 +472,7 @@ export default {
this.$ui = new shaka.ui.Overlay(localPlayer, this.$refs.container, videoEl);
const overflowMenuButtons = [
"quality",
"language",
"captions",
"picture_in_picture",
"playback_rate",
"airplay",
];
const overflowMenuButtons = ["quality", "captions", "picture_in_picture", "playback_rate", "airplay"];
if (this.isEmbed) {
overflowMenuButtons.push("open_new_tab");
@ -544,6 +537,18 @@ export default {
player.selectAudioLanguage(lang);
}
const audioLanguages = player.getAudioLanguages();
if (audioLanguages.length > 1) {
const overflowMenuButtons = this.$ui.getConfiguration().overflowMenuButtons;
// append language menu on index 1
const newOverflowMenuButtons = [
...overflowMenuButtons.slice(0, 1),
"language",
...overflowMenuButtons.slice(1),
];
this.$ui.configure("overflowMenuButtons", newOverflowMenuButtons);
}
if (qualityConds) {
var leastDiff = Number.MAX_VALUE;
var bestStream = null;