Add better error messages for localStorage disabled.

This commit is contained in:
Kavin 2022-11-07 10:20:13 +00:00
parent d1c403765c
commit 6b9151e47f
No known key found for this signature in database
GPG key ID: 49451E4482CC5BCD
6 changed files with 28 additions and 9 deletions

View file

@ -195,7 +195,7 @@ export default {
}, },
}); });
} else { } else {
this.handleLocalSubscriptions(this.channel.id); if (!this.handleLocalSubscriptions(this.channel.id)) return;
} }
this.subscribed = !this.subscribed; this.subscribed = !this.subscribed;
}, },

View file

@ -158,7 +158,11 @@ export default {
: [...new Set((this.getLocalSubscriptions() ?? []).concat(newChannels))]; : [...new Set((this.getLocalSubscriptions() ?? []).concat(newChannels))];
// Sort for better cache hits // Sort for better cache hits
subscriptions.sort(); subscriptions.sort();
try {
localStorage.setItem("localSubscriptions", JSON.stringify(subscriptions)); localStorage.setItem("localSubscriptions", JSON.stringify(subscriptions));
} catch (e) {
alert(this.$t("info.local_storage"));
}
}, },
}, },
}; };

View file

@ -137,8 +137,8 @@ export default {
shouldShowTrending(_this) { shouldShowTrending(_this) {
return _this.getPreferenceString("homepage", "trending") != "trending"; return _this.getPreferenceString("homepage", "trending") != "trending";
}, },
showSearchHistory() { showSearchHistory(_this) {
return localStorage.getItem("searchHistory") && localStorage.getItem("search_history"); return _this.getPreferenceBoolean("searchHistory", false) && localStorage.getItem("search_history");
}, },
}, },
methods: { methods: {

View file

@ -485,7 +485,7 @@ export default {
}, },
}); });
} else { } else {
this.handleLocalSubscriptions(this.channelId); if (!this.handleLocalSubscriptions(this.channelId)) return;
} }
this.subscribed = !this.subscribed; this.subscribed = !this.subscribed;
}, },

View file

@ -167,6 +167,7 @@
"preferences_note": "Note: preferences are saved in the local storage of your browser. Deleting your browser data will reset them.", "preferences_note": "Note: preferences are saved in the local storage of your browser. Deleting your browser data will reset them.",
"page_not_found": "Page not found", "page_not_found": "Page not found",
"copied": "Copied!", "copied": "Copied!",
"cannot_copy": "Can't copy!" "cannot_copy": "Can't copy!",
"local_storage": "This action requires localStorage, are cookies enabled?"
} }
} }

View file

@ -119,7 +119,11 @@ const mixin = {
return DOMPurify.sanitize(original); return DOMPurify.sanitize(original);
}, },
setPreference(key, value) { setPreference(key, value) {
if (localStorage) localStorage.setItem(key, value); try {
localStorage.setItem(key, value);
} catch {
alert(this.$t("info.local_storage"));
}
}, },
getPreferenceBoolean(key, defaultVal) { getPreferenceBoolean(key, defaultVal) {
var value; var value;
@ -204,7 +208,11 @@ const mixin = {
} }
}, },
getLocalSubscriptions() { getLocalSubscriptions() {
try {
return JSON.parse(localStorage.getItem("localSubscriptions")); return JSON.parse(localStorage.getItem("localSubscriptions"));
} catch {
return [];
}
}, },
isSubscribedLocally(channelId) { isSubscribedLocally(channelId) {
const localSubscriptions = this.getLocalSubscriptions(); const localSubscriptions = this.getLocalSubscriptions();
@ -218,7 +226,13 @@ const mixin = {
else localSubscriptions.push(channelId); else localSubscriptions.push(channelId);
// Sort for better cache hits // Sort for better cache hits
localSubscriptions.sort(); localSubscriptions.sort();
try {
localStorage.setItem("localSubscriptions", JSON.stringify(localSubscriptions)); localStorage.setItem("localSubscriptions", JSON.stringify(localSubscriptions));
return true;
} catch {
alert(this.$t("info.local_storage"));
}
return false;
}, },
getUnauthenticatedChannels() { getUnauthenticatedChannels() {
const localSubscriptions = this.getLocalSubscriptions() ?? []; const localSubscriptions = this.getLocalSubscriptions() ?? [];