TeamPiped-mirror/Piped
1
0
Fork 0
mirror of https://github.com/TeamPiped/Piped.git synced 2024-08-14 23:57:27 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix strange vuejs event cycle when keep-alive limit is hit.

Browse source
This commit is contained in:
FireMasterK 2021-09-06 02:23:59 +05:30
parent 3dc0287dff
commit 07dfa21956
No known key found for this signature in database
GPG key ID: 49451E4482CC5BCD
4 changed files with 32 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/components/Channel.vue
View file

@ -2,7 +2,9 @@
<ErrorHandler v-if="channel && channel.error" :message="channel.message" :error="channel.error" />
<div v-if="channel" v-show="!channel.error">
<h1 class="uk-text-center"><img height="48" width="48" class="uk-border-circle" v-bind:src="channel.avatarUrl" />{{ channel.name }}</h1>
<h1 class="uk-text-center">
<img height="48" width="48" class="uk-border-circle" v-bind:src="channel.avatarUrl" />{{ channel.name }}
</h1>
<img v-if="channel.bannerUrl" v-bind:src="channel.bannerUrl" style="width: 100%" loading="lazy" />
<p style="white-space: pre-wrap"><span v-html="purifyHTML(urlify(channel.description))"></span></p>
@ -52,6 +54,9 @@ export default {
deactivated() {
window.removeEventListener("scroll", this.handleScroll);
},
unmounted() {
window.removeEventListener("scroll", this.handleScroll);
},
methods: {
async fetchSubscribedStatus() {
this.fetchJson(

28
src/components/Player.vue
View file

@ -280,6 +280,19 @@ export default {
videoEl.volume = this.getPreferenceNumber("volume", 1);
});
},
destroy() {
if (this.ui) {
this.ui.destroy();
this.ui = undefined;
this.player = undefined;
}
if (this.player) {
this.player.destroy();
this.player = undefined;
}
if (this.hotkeys) this.hotkeys.unbind();
if (this.$refs.container) this.$refs.container.querySelectorAll("div").forEach(node => node.remove());
},
},
activated() {
import("hotkeys-js")
@ -334,17 +347,10 @@ export default {
});
},
deactivated() {
if (this.ui) {
this.ui.destroy();
this.ui = undefined;
this.player = undefined;
}
if (this.player) {
this.player.destroy();
this.player = undefined;
}
if (this.hotkeys) this.hotkeys.unbind();
if (this.$refs.container) this.$refs.container.querySelectorAll("div").forEach(node => node.remove());
this.destroy();
},
unmounted() {
this.destroy();
},
};
</script>

7
src/components/SearchResults.vue
View file

@ -49,7 +49,9 @@
</router-link>
<a v-if="result.uploaderName" class="uk-text-muted">{{ result.uploaderName }}</a>
<b v-if="result.videos >= 0"><br v-if="result.uploaderName" />{{ result.videos }} {{ $t("video.videos") }}</b>
<b v-if="result.videos >= 0"
><br v-if="result.uploaderName" />{{ result.videos }} {{ $t("video.videos") }}</b
>
<br />
</div>
@ -86,6 +88,9 @@ export default {
deactivated() {
window.removeEventListener("scroll", this.handleScroll);
},
unmounted() {
window.removeEventListener("scroll", this.handleScroll);
},
methods: {
async fetchResults() {
return await await this.fetchJson(this.apiUrl() + "/search", {

3
src/components/WatchVideo.vue
View file

@ -179,6 +179,9 @@ export default {
this.active = false;
window.removeEventListener("scroll", this.handleScroll);
},
beforeUnmount() {
window.removeEventListener("scroll", this.handleScroll);
},
methods: {
fetchVideo() {
return this.fetchJson(this.apiUrl() + "/streams/" + this.getVideoId());