future proofed SyncID

app/src/main/java/com/lagradost/cloudstream3/syncproviders/SyncAPI.kt

@@ -138,7 +138,11 @@ interface SyncAPI : OAuth2API {
     data class LibraryItem(
         override val name: String,
         override val url: String,
-        /** Unique unchanging string used for data storage */
+        /**
+         * Unique unchanging string used for data storage.
+         * This should be the actual id when you change scores and status
+         * since score changes from library might get added in the future.
+         **/
         val syncId: String,
         val episodesCompleted: Int?,
         val episodesTotal: Int?,

app/src/main/java/com/lagradost/cloudstream3/syncproviders/providers/LocalList.kt

@@ -72,7 +72,7 @@ class LocalList : SyncAPI {
                 it.second.stringRes
             }.mapValues { group ->
                 group.value.mapNotNull {
-                    getBookmarkedData(it.first)?.toLibraryItem()
+                    getBookmarkedData(it.first)?.toLibraryItem(it.first.toString())
                 }
             }
         }

app/src/main/java/com/lagradost/cloudstream3/utils/DataStoreHelper.kt

@@ -55,16 +55,16 @@ object DataStoreHelper {
         @JsonProperty("quality") override var quality: SearchQuality? = null,
         @JsonProperty("posterHeaders") override var posterHeaders: Map<String, String>? = null,
     ) : SearchResponse {
-        fun toLibraryItem(): SyncAPI.LibraryItem {
+        fun toLibraryItem(id: String): SyncAPI.LibraryItem {
             return SyncAPI.LibraryItem(
                 name,
                 url,
-                url,
+                id,
                 null,
                 null,
                 null,
                 null,
-                apiName, type, posterUrl, posterHeaders, quality, id
+                apiName, type, posterUrl, posterHeaders, quality, this.id
             )
         }
     }