Mguy13/covid_10012023_covid-reports
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Initial commit

Browse source
This commit is contained in:
Mehul Ahal 2023-01-10 16:20:16 +01:00 committed by LahaLuhem
parent 6ee2c5a715
commit b7cac335ec
5 changed files with 24 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
.idea/.gitignore vendored Normal file
View file

@ -0,0 +1,3 @@
# Default ignored files
/shelf/
/workspace.xml

6
.idea/misc.xml Normal file
View file

@ -0,0 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<project version="4">
<component name="ProjectRootManager" version="2" languageLevel="JDK_19" default="true" project-jdk-name="19" project-jdk-type="JavaSDK">
<output url="file://$PROJECT_DIR$/out" />
</component>
</project>

8
.idea/modules.xml Normal file
View file

@ -0,0 +1,8 @@
<?xml version="1.0" encoding="UTF-8"?>
<project version="4">
<component name="ProjectModuleManager">
<modules>
<module fileurl="file://$PROJECT_DIR$/covid_10012023_MehulAhal_covid-reports.iml" filepath="$PROJECT_DIR$/covid_10012023_MehulAhal_covid-reports.iml" />
</modules>
</component>
</project>

6
.idea/vcs.xml Normal file
View file

@ -0,0 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<project version="4">
<component name="VcsDirectoryMappings">
<mapping directory="$PROJECT_DIR$" vcs="Git" />
</component>
</project>

2
README.md
View file

@ -52,4 +52,4 @@ Here are some points that I could have improved upon, but did not go through wit
+ The AppConfigService class should be refactored to use a more robust input validation library, to handle more edge cases. + The AppConfigService class should be refactored to use a more robust input validation library, to handle more edge cases.
+ The ReportGenerationService class should be refactored to support more output formats, such as HTML, CSV and PDF. + The ReportGenerationService class should be refactored to support more output formats, such as HTML, CSV and PDF.
+ The Main class is using exceptions for flow control, it would be better to use specific exception classes for different error conditions, and handle them accordingly. + The Main class is using exceptions for flow control, it would be better to use specific exception classes for different error conditions, and handle them accordingly.
+ The Main class is catching a general SQLException and rethrowing it as a runtime exception, but it would be better to handle specific SQLException subclasses and provide more informative error messages. + The Main class is catching a general SQLException and rethrowing it as a runtime exception, but it would be better to handle specific SQLException subclasses and provide more informative error messages.