From 1064397350f5abfa7ad930057870370779abb5cc Mon Sep 17 00:00:00 2001
From: rhysd <lin90162@yahoo.co.jp>
Date: Wed, 3 Jan 2018 23:13:23 +0900
Subject: [PATCH] fix tests which used a not-existing path

---
 selfupdate/testdata/fake-executable     |  1 +
 selfupdate/testdata/fake-executable.exe |  1 +
 selfupdate/update_test.go               | 26 ++++++++++++++++++++++---
 3 files changed, 25 insertions(+), 3 deletions(-)
 create mode 100644 selfupdate/testdata/fake-executable
 create mode 100644 selfupdate/testdata/fake-executable.exe

diff --git a/selfupdate/testdata/fake-executable b/selfupdate/testdata/fake-executable
new file mode 100644
index 0000000..2fcb8d1
--- /dev/null
+++ b/selfupdate/testdata/fake-executable
@@ -0,0 +1 @@
+this file is used for passing check of file existence in update tests.
diff --git a/selfupdate/testdata/fake-executable.exe b/selfupdate/testdata/fake-executable.exe
new file mode 100644
index 0000000..2fcb8d1
--- /dev/null
+++ b/selfupdate/testdata/fake-executable.exe
@@ -0,0 +1 @@
+this file is used for passing check of file existence in update tests.
diff --git a/selfupdate/update_test.go b/selfupdate/update_test.go
index c1aa07f..11deac3 100644
--- a/selfupdate/update_test.go
+++ b/selfupdate/update_test.go
@@ -64,6 +64,13 @@ func TestUpdateCommand(t *testing.T) {
 }
 
 func TestUpdateViaSymlink(t *testing.T) {
+	if testing.Short() {
+		t.Skip("skip tests in short mode.")
+	}
+	if runtime.GOOS == "windows" {
+		t.Skip("skipping because creating symlink on windows requires the root privilege")
+	}
+
 	setupTestBinary()
 	defer teardownTestBinary()
 	if err := os.Symlink("github-release-test", "github-release-test-sym"); err != nil {
@@ -108,6 +115,10 @@ func TestUpdateViaSymlink(t *testing.T) {
 }
 
 func TestUpdateBrokenSymlinks(t *testing.T) {
+	if runtime.GOOS == "windows" {
+		t.Skip("skipping because creating symlink on windows requires the root privilege")
+	}
+
 	// unknown-xxx -> unknown-yyy -> {not existing}
 	if err := os.Symlink("not-existing", "unknown-yyy"); err != nil {
 		t.Fatal(err)
@@ -142,7 +153,8 @@ func TestNotExistingCommandPath(t *testing.T) {
 
 func TestNoReleaseFoundForUpdate(t *testing.T) {
 	v := semver.MustParse("1.0.0")
-	rel, err := UpdateCommand("foo", v, "rhysd/misc")
+	fake := filepath.FromSlash("./testdata/fake-executable")
+	rel, err := UpdateCommand(fake, v, "rhysd/misc")
 	if err != nil {
 		t.Fatal("No release should not make an error:", err)
 	}
@@ -161,6 +173,12 @@ func TestNoReleaseFoundForUpdate(t *testing.T) {
 }
 
 func TestCurrentIsTheLatest(t *testing.T) {
+	if testing.Short() {
+		t.Skip("skip tests in short mode.")
+	}
+	setupTestBinary()
+	defer teardownTestBinary()
+
 	v := semver.MustParse("1.2.3")
 	rel, err := UpdateCommand("github-release-test", v, "rhysd-test/test-release-zip")
 	if err != nil {
@@ -185,7 +203,8 @@ func TestBrokenBinaryUpdate(t *testing.T) {
 		t.Skip("skip tests in short mode.")
 	}
 
-	_, err := UpdateCommand("foo", semver.MustParse("1.2.2"), "rhysd-test/test-incorrect-release")
+	fake := filepath.FromSlash("./testdata/fake-executable")
+	_, err := UpdateCommand(fake, semver.MustParse("1.2.2"), "rhysd-test/test-incorrect-release")
 	if err == nil {
 		t.Fatal("Error should occur for broken package")
 	}
@@ -195,7 +214,8 @@ func TestBrokenBinaryUpdate(t *testing.T) {
 }
 
 func TestInvalidSlugForUpdate(t *testing.T) {
-	_, err := UpdateCommand("foo", semver.MustParse("1.0.0"), "rhysd/")
+	fake := filepath.FromSlash("./testdata/fake-executable")
+	_, err := UpdateCommand(fake, semver.MustParse("1.0.0"), "rhysd/")
 	if err == nil {
 		t.Fatal("Unknown repo should cause an error")
 	}