From 0ca6c2a6e602b725a2e7be7518d8dcc43359552e Mon Sep 17 00:00:00 2001
From: Blatzar <46196380+Blatzar@users.noreply.github.com>
Date: Thu, 11 Aug 2022 18:54:21 +0200
Subject: [PATCH] Fix images in plugins list

---
 .../ui/settings/extensions/PluginAdapter.kt          | 12 ++++++++++--
 .../ui/settings/extensions/RepoAdapter.kt            |  8 ++++++++
 2 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/app/src/main/java/com/lagradost/cloudstream3/ui/settings/extensions/PluginAdapter.kt b/app/src/main/java/com/lagradost/cloudstream3/ui/settings/extensions/PluginAdapter.kt
index 743179a2..7bbc7d82 100644
--- a/app/src/main/java/com/lagradost/cloudstream3/ui/settings/extensions/PluginAdapter.kt
+++ b/app/src/main/java/com/lagradost/cloudstream3/ui/settings/extensions/PluginAdapter.kt
@@ -10,6 +10,7 @@ import androidx.recyclerview.widget.RecyclerView
 import com.lagradost.cloudstream3.PROVIDER_STATUS_DOWN
 import com.lagradost.cloudstream3.R
 import com.lagradost.cloudstream3.plugins.PluginManager
+import com.lagradost.cloudstream3.utils.GlideApp
 import com.lagradost.cloudstream3.utils.UIHelper.setImage
 import kotlinx.android.synthetic.main.repository_item.view.*
 
@@ -61,6 +62,14 @@ class PluginAdapter(
         return PluginManager.getPluginsOnline().also { storedPlugins = it }
     }*/
 
+    // Clear glide image because setImageResource doesn't override
+    override fun onViewRecycled(holder: RecyclerView.ViewHolder) {
+        holder.itemView.entry_icon?.let { pluginIcon ->
+            GlideApp.with(pluginIcon).clear(pluginIcon)
+        }
+        super.onViewRecycled(holder)
+    }
+
     inner class PluginViewHolder(itemView: View) :
         RecyclerView.ViewHolder(itemView) {
 
@@ -98,8 +107,7 @@ class PluginAdapter(
                 }
             }
 
-            if (metadata.iconUrl == null ||
-                itemView.entry_icon?.setImage(metadata.iconUrl, null) != true) {
+            if (itemView.entry_icon?.setImage(metadata.iconUrl, null) != true) {
                 itemView.entry_icon?.setImageResource(R.drawable.ic_baseline_extension_24)
             }
 
diff --git a/app/src/main/java/com/lagradost/cloudstream3/ui/settings/extensions/RepoAdapter.kt b/app/src/main/java/com/lagradost/cloudstream3/ui/settings/extensions/RepoAdapter.kt
index 960f0c19..1949894a 100644
--- a/app/src/main/java/com/lagradost/cloudstream3/ui/settings/extensions/RepoAdapter.kt
+++ b/app/src/main/java/com/lagradost/cloudstream3/ui/settings/extensions/RepoAdapter.kt
@@ -30,6 +30,14 @@ class RepoAdapter(
         }
     }
 
+    // Clear glide image because setImageResource doesn't override
+//    override fun onViewRecycled(holder: RecyclerView.ViewHolder) {
+//        holder.itemView.entry_icon?.let { repoIcon ->
+//            GlideApp.with(repoIcon).clear(repoIcon)
+//        }
+//        super.onViewRecycled(holder)
+//    }
+
     override fun getItemCount(): Int {
         return repositories.size
     }