From b8a3009c9d763b5efb6098bd1f8f7d54521d15f8 Mon Sep 17 00:00:00 2001 From: Camotoy <20743703+DoctorMacc@users.noreply.github.com> Date: Sat, 30 May 2020 18:31:20 -0400 Subject: [PATCH] Ignore all downstream packet errors (#693) * Ignore all downstream packet errors Instead of kicking the client off because of an error, we simply display a logger warning and suppress the error. * If debug mode, print stacktrace --- connector/pom.xml | 2 +- .../geysermc/connector/network/session/GeyserSession.java | 8 ++++++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/connector/pom.xml b/connector/pom.xml index 229761ad..5743c0c6 100644 --- a/connector/pom.xml +++ b/connector/pom.xml @@ -105,7 +105,7 @@ com.github.steveice10 packetlib - 1.5-SNAPSHOT + 1.6-SNAPSHOT compile diff --git a/connector/src/main/java/org/geysermc/connector/network/session/GeyserSession.java b/connector/src/main/java/org/geysermc/connector/network/session/GeyserSession.java index cc052509..ad5caf14 100644 --- a/connector/src/main/java/org/geysermc/connector/network/session/GeyserSession.java +++ b/connector/src/main/java/org/geysermc/connector/network/session/GeyserSession.java @@ -366,6 +366,14 @@ public class GeyserSession implements CommandSender { PacketTranslatorRegistry.JAVA_TRANSLATOR.translate(event.getPacket().getClass(), event.getPacket(), GeyserSession.this); } } + + @Override + public void packetError(PacketErrorEvent event) { + connector.getLogger().warning("Downstream packet error! " + event.getCause().getMessage()); + if (connector.getConfig().isDebugMode()) + event.getCause().printStackTrace(); + event.setSuppress(true); + } }); downstream.getSession().connect();