From 27a17ff18376257b5b5abd0ab0f553fe13b3bef5 Mon Sep 17 00:00:00 2001 From: Camotoy <20743703+Camotoy@users.noreply.github.com> Date: Wed, 22 Sep 2021 19:27:49 -0400 Subject: [PATCH] Fix firework stars being unobtainable from the creative menu --- .../org/geysermc/connector/registry/type/ItemMappings.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/connector/src/main/java/org/geysermc/connector/registry/type/ItemMappings.java b/connector/src/main/java/org/geysermc/connector/registry/type/ItemMappings.java index 767b6b2e0..bffe415a1 100644 --- a/connector/src/main/java/org/geysermc/connector/registry/type/ItemMappings.java +++ b/connector/src/main/java/org/geysermc/connector/registry/type/ItemMappings.java @@ -121,8 +121,9 @@ public class ItemMappings { } } else { if (!(mapping.getBedrockData() == data.getDamage() || - // Make exceptions for potions and tipped arrows, whose damage values can vary - (mapping.getJavaIdentifier().endsWith("potion") || mapping.getJavaIdentifier().equals("minecraft:arrow")))) { + // Make exceptions for potions, tipped arrows, and firework stars, whose damage values can vary + (mapping.getJavaIdentifier().endsWith("potion") || mapping.getJavaIdentifier().equals("minecraft:arrow") + || mapping.getJavaIdentifier().equals("minecraft:firework_star")))) { continue; } }