From 0335c8263c21e30a28baa0f34a9eb97dbe808de3 Mon Sep 17 00:00:00 2001 From: Kas-tle <26531652+Kas-tle@users.noreply.github.com> Date: Wed, 13 Jul 2022 16:20:42 +0000 Subject: [PATCH] Address @Camotoy's review --- bootstrap/spigot/build.gradle.kts | 2 +- build-logic/src/main/kotlin/Versions.kt | 2 ++ settings.gradle.kts | 7 ++++++- 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/bootstrap/spigot/build.gradle.kts b/bootstrap/spigot/build.gradle.kts index 5a12ded01..02883999d 100644 --- a/bootstrap/spigot/build.gradle.kts +++ b/bootstrap/spigot/build.gradle.kts @@ -1,6 +1,6 @@ val paperVersion = "1.19-R0.1-SNAPSHOT" val viaVersion = "4.0.0" -val adaptersVersion = "1.4-SNAPSHOT" +val adaptersVersion = "1.5-SNAPSHOT" val commodoreVersion = "1.13" dependencies { diff --git a/build-logic/src/main/kotlin/Versions.kt b/build-logic/src/main/kotlin/Versions.kt index 919935409..27f7bcaf5 100644 --- a/build-logic/src/main/kotlin/Versions.kt +++ b/build-logic/src/main/kotlin/Versions.kt @@ -31,6 +31,8 @@ object Versions { const val nbtVersion = "2.1.0" const val websocketVersion = "1.5.1" const val protocolVersion = "a78a64b" + // Not pinned to specific version due to possible gradle bug + // See comment in settings.gradle.kts const val raknetVersion = "1.6.28-SNAPSHOT" const val mcauthlibVersion = "d9d773e" const val mcprotocollibversion = "54fc9f0" diff --git a/settings.gradle.kts b/settings.gradle.kts index 0bc694b43..dd08f3922 100644 --- a/settings.gradle.kts +++ b/settings.gradle.kts @@ -8,7 +8,12 @@ dependencyResolutionManagement { mavenContent { releasesOnly() } } maven("https://repo.opencollab.dev/maven-snapshots") { - mavenContent { snapshotsOnly() } + mavenContent { + // This has the unintended side effect of not allowing snapshot version pinning. + // Likely a bug in Gradle's implementation of snapshot pinning + // See https://github.com/gradle/gradle/pull/406 + snapshotsOnly() + } } // Paper, Velocity