From 007edcbf11fd5c851433201e6e00538d7ad19be6 Mon Sep 17 00:00:00 2001
From: chris <reichel32574@gmail.com>
Date: Sat, 9 Sep 2023 00:13:57 +0200
Subject: [PATCH] Fix: Update inventory names (#4106)

Ensure inventory name updates used for e.g. JsonUI work properly.
---
 .../protocol/java/inventory/JavaOpenScreenTranslator.java      | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/core/src/main/java/org/geysermc/geyser/translator/protocol/java/inventory/JavaOpenScreenTranslator.java b/core/src/main/java/org/geysermc/geyser/translator/protocol/java/inventory/JavaOpenScreenTranslator.java
index fd733773e..3a18e0b78 100644
--- a/core/src/main/java/org/geysermc/geyser/translator/protocol/java/inventory/JavaOpenScreenTranslator.java
+++ b/core/src/main/java/org/geysermc/geyser/translator/protocol/java/inventory/JavaOpenScreenTranslator.java
@@ -73,7 +73,8 @@ public class JavaOpenScreenTranslator extends PacketTranslator<ClientboundOpenSc
         if (openInventory != null) {
             // If the window type is the same, don't close.
             // In rare cases, inventories can do funny things where it keeps the same window type up but change the contents.
-            if (openInventory.getContainerType() != packet.getType()) {
+            // Or, inventory names can change (useful for JsonUI). In these cases, we need to close the old inventory.
+            if (openInventory.getContainerType() != packet.getType() || !openInventory.getTitle().equals(name)) {
                 // Sometimes the server can double-open an inventory with the same ID - don't confirm in that instance.
                 InventoryUtils.closeInventory(session, openInventory.getJavaId(), openInventory.getJavaId() != packet.getContainerId());
             }