Commit graph

759 commits

Author SHA1 Message Date
Stypox
1e1100ef76
Update extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeStreamExtractor.java
Co-Authored-By: Tobias Groza <TobiGr@users.noreply.github.com>
2020-01-20 22:52:36 +01:00
TobiGr
2308b074f0 [MediaCCC] Fix testGetTextualUploadDate() 2020-01-20 22:12:39 +01:00
TobiGr
089dbe8afb Fix StreamLinkHandlerFactoryTest by passing baseUrl to vdn.youtube urls 2020-01-20 22:10:18 +01:00
f403490bd9
Refactoring
Co-Authored-By: Tobias Groza <TobiGr@users.noreply.github.com>
2020-01-20 21:28:26 +01:00
TobiGr
69ccb7e69d Update subtitle tests comments 2020-01-20 21:25:47 +01:00
TobiGr
7943130307 Throw IllegalArgumentException when url is null in LinkHandlerFactory 2020-01-20 21:25:16 +01:00
TobiGr
39de55dcd3 [YouTube] Fix and move streamCountTest 2020-01-20 21:24:51 +01:00
TobiGr
51fd9ba491 Merge branch 'master' into dev 2020-01-20 20:31:32 +01:00
ad7f97ae83 fix PeerTube description and add more description tests
actually, the max description length is 250 after request with our extractor.
during my tests, I made API requests with Firefox, copy/pasted into echo "insert description" | wc, and it was giving a wrong length, maybe due to the escapers, I have no idea
anyway, it's now fixed
2020-01-20 15:14:23 +01:00
b382416372 changed the way to extract peertube description
if the description length is above 254, and ends with ..., it means the description we got from the first request is shortened.
why above 254: because in fact, shortened descriptions length are between 255 : https://framatube.org/videos/watch/24efbe1b-73c0-4d72-a3ff-77c8b32d3fcd
https://framatube.org/videos/watch/1ca99f40-fb5b-4fa4-abe5-4d54325df7fc
and 269: https://framatube.org/videos/watch/4d661d5f-a884-4510-bca8-15cb19aa3fe5

also fixed a typo in StreamExtractor.java
2020-01-20 14:36:12 +01:00
a281519e77 added metadata, fix descriptions, fix thumbnail, update tests
thumbnail: quality before: https://peertube.cpy.re/static/thumbnails/d2a5ec78-5f85-4090-8ec5-dc1102e022ea.jpg
quality after: https://peertube.cpy.re/static/previews/d2a5ec78-5f85-4090-8ec5-dc1102e022ea.jpg

description: we were getting about the first 260 characters, we now get full description (with fallback to first 260 chars if the get request for full description fails)
test: updated tests to match description, also changed some test: it was assertEquals(extracted, expected), but the proper way to do it is assertEquals(expected, extracted)

metadata: got host, privacy (public, private, unlisted), licence, language, tags
2020-01-20 12:22:33 +01:00
TobiGr
c1e1ac1f57 Merge branch 'dev' 2020-01-19 10:13:14 +01:00
Tobias Groza
2ee558fbe7
Merge pull request #237 from B0pol/fix_invidious_comments
Fix invidious comments
2020-01-17 22:55:51 +01:00
Tobias Groza
5a259fca94
Merge pull request #238 from B0pol/c_links_support
add support to /c/shortened_url channel links
2020-01-17 22:53:46 +01:00
Tobias Groza
57cf47b9f3
Merge pull request #236 from B0pol/fix_typos
fix: typos in Test
2020-01-17 22:52:29 +01:00
221e8dd171 changed assertTrue(string.equals(string)) to assertEquals(string, string) 2020-01-17 21:24:52 +01:00
5e81ed1dff add support to /c/shortened_url channel links 2020-01-17 19:27:54 +01:00
7e8d00981f changed getId() to remove duplicate code 2020-01-17 13:44:55 +01:00
02930d08f1 added comments test for invidious 2020-01-17 12:58:50 +01:00
a12c0e2a37 fix:invidious: getID and onAccpetURl for comments 2020-01-17 12:09:59 +01:00
3743c60695 fix: typos in Test 2020-01-15 14:27:52 +01:00
TobiGr
4aaf123f24 Add PeerTube to supported services in README 2020-01-14 15:36:25 +01:00
Stypox
0567c20549
Merge branch 'dev' into yt-stream-ext 2020-01-07 00:10:06 +01:00
Stypox
7ba04836eb
Add tests for ratings in yt stream extractor tests 2020-01-06 23:57:08 +01:00
Stypox
1bb6cdee22
Enable commented-out test for yt stream extractor 2020-01-06 21:43:24 +01:00
Stypox
d5ca02f3f6
Fix test failing because music channel could be Vevo
In yt stream extractor test.
The Vevo and the normal music channel are equivalent, so Youtube picks one of them at random, and in playerResponse the channel id is Vevo's one.
2020-01-06 21:41:15 +01:00
Stypox
1689037b01
Fix getLength() tests now that the value is rounded (not floor-ed)
In yt stream extractor
2020-01-06 20:49:08 +01:00
Stypox
1ed89aad3e
Use more often playerResponse in yt stream extractor
This enhances performance and should make the extractor more reliable since it get info from a stable json structure that shouldn't be subject to many changes. Fallback html methods have been kept. In case of error the thrown exception contains the data about the playerResponse failure, that should be clearer than a NPE caused by not-found html tags.
2020-01-06 20:45:57 +01:00
Tobias Groza
bdbfa26835
Merge pull request #231 from pihug12/dev
[Soundcloud] Update client_id
2020-01-06 11:21:27 +01:00
pihug12
d4e0930f44 [Soundcloud] Update client_id 2019-12-31 23:36:23 +01:00
Tobias Groza
d83787a5ca
Merge pull request #226 from 7FM/dev
fix switching on null causing NPE
2019-12-31 00:26:27 +01:00
Tobias Groza
1c0a5db6da
Merge pull request #215 from gzsombor/fix-search-paging
Fix search result paging
2019-12-31 00:25:23 +01:00
TobiGr
0b6e37e71f Improve YouTubeSearchPagingtest 2019-12-31 00:18:53 +01:00
Zsombor Gegesy
64729e5357 Improve the tests 2019-12-29 23:14:55 +01:00
Zsombor Gegesy
68b0fd9650 Add test for search paging 2019-12-29 23:14:55 +01:00
Zsombor Gegesy
2123b3abd3 Fix search result paging - due to the way as the InfoItemsSearchCollector are re-used,
the returned item list just grows, which cause that same videos are returned.
2019-12-29 23:14:55 +01:00
TobiGr
305ff21770 use openjdk8 for travis build 2019-12-26 23:38:40 +01:00
TobiGr
f826c24749 Use UTF-8 encoding for docs and bump version to v0.18.0 2019-12-26 22:46:19 +01:00
TobiGr
01eb7a9658 Fix syntax 2019-12-26 22:22:46 +01:00
TobiGr
147322b526 Deploy JDoc even when tests on master fail 2019-12-26 22:11:12 +01:00
Zsombor Gegesy
0a3422a591 Fix invalid jsoup query 2019-12-26 14:03:40 +01:00
7FM
fd5ed07d33
Merge branch 'dev' into dev 2019-12-22 12:33:26 +01:00
TobiGr
8e53fdad16 [SoundCloud] Fix getAudioStreams 401 response
Fix TeamNewPipe/NewPipe#2823
2019-12-22 00:42:07 +01:00
7FM
f57d9d43ce fix switching on null causing NPE 2019-12-21 14:15:42 +01:00
Tobias Groza
8cb32501e7
Merge pull request #217 from TeamNewPipe/fix/SC_client_id
Fix SoundCloud client_id extraction and update SoundCloud client_id
2019-12-12 18:11:42 +01:00
TobiGr
54d1a1a831 Fix SoundCloud client_id extraction and update SoundCloud client_id
Don't throw exception when hard coded client_id is wrong.
Addresses TeamNewPipe/NewPipe#2823
2019-12-12 18:01:48 +01:00
Tobias Groza
be79f20217
Merge pull request #219 from Redirion/patch-1
Allow PlayLists with missing uploader
2019-12-12 17:58:57 +01:00
Redirion
035994b3cf
Update PlaylistInfo.java
added missing imports
2019-12-09 16:55:28 +01:00
Redirion
e98112ea21
Update PlaylistInfo.java
Fixed typo
2019-12-07 14:34:15 +01:00
Redirion
cdf41b868c
Allow PlayLists with missing uploader
This supports PR 2724 in NewPipe
2019-12-07 12:49:42 +01:00