Fixed ``SoundcloudStreamLinkHandlerFactoryTest``
* Removed the unnecessary ``public`` * Use parameterized tests * One song got removed (which caused the test failure), replaced it with another song
This commit is contained in:
litetex
parent
504f81036e
commit
bf3ae5e679
|
|
@ -2,6 +2,9 @@ package org.schabi.newpipe.extractor.services.soundcloud;
|
|||
|
||||
import org.junit.jupiter.api.BeforeAll;
|
||||
import org.junit.jupiter.api.Test;
|
||||
import org.junit.jupiter.params.ParameterizedTest;
|
||||
import org.junit.jupiter.params.provider.CsvSource;
|
||||
import org.junit.jupiter.params.provider.ValueSource;
|
||||
import org.schabi.newpipe.downloader.DownloaderTestImpl;
|
||||
import org.schabi.newpipe.extractor.NewPipe;
|
||||
import org.schabi.newpipe.extractor.exceptions.ParsingException;
|
||||
|
|
@ -25,57 +28,54 @@ public class SoundcloudStreamLinkHandlerFactoryTest {
|
|||
}
|
||||
|
||||
@Test
|
||||
public void getIdWithNullAsUrl() {
|
||||
void getIdWithNullAsUrl() {
|
||||
assertThrows(IllegalArgumentException.class, () -> linkHandler.fromUrl(null));
|
||||
}
|
||||
|
||||
@Test
|
||||
public void getIdForInvalidUrls() {
|
||||
List<String> invalidUrls = new ArrayList<>(50);
|
||||
invalidUrls.add("https://soundcloud.com/liluzivert/t.e.s.t");
|
||||
invalidUrls.add("https://soundcloud.com/liluzivert/tracks");
|
||||
invalidUrls.add("https://soundcloud.com/");
|
||||
for (String invalidUrl : invalidUrls) {
|
||||
Throwable exception = null;
|
||||
try {
|
||||
linkHandler.fromUrl(invalidUrl).getId();
|
||||
} catch (ParsingException e) {
|
||||
exception = e;
|
||||
}
|
||||
if (exception == null) {
|
||||
fail("Expected ParsingException for url: " + invalidUrl);
|
||||
}
|
||||
}
|
||||
@ParameterizedTest
|
||||
@ValueSource(strings = {
|
||||
"https://soundcloud.com/liluzivert/t.e.s.t",
|
||||
"https://soundcloud.com/liluzivert/tracks",
|
||||
"https://soundcloud.com/"
|
||||
})
|
||||
void getIdForInvalidUrls(final String invalidUrl) {
|
||||
assertThrows(ParsingException.class, () -> linkHandler.fromUrl(invalidUrl).getId());
|
||||
}
|
||||
|
||||
@Test
|
||||
public void getId() throws Exception {
|
||||
assertEquals("309689103", linkHandler.fromUrl("https://soundcloud.com/liluzivert/15-ysl").getId());
|
||||
assertEquals("309689082", linkHandler.fromUrl("https://www.soundcloud.com/liluzivert/15-luv-scars-ko").getId());
|
||||
assertEquals("309689035", linkHandler.fromUrl("http://soundcloud.com/liluzivert/15-boring-shit").getId());
|
||||
assertEquals("259273264", linkHandler.fromUrl("https://soundcloud.com/liluzivert/ps-qs-produced-by-don-cannon/").getId());
|
||||
assertEquals("294488599", linkHandler.fromUrl("http://www.soundcloud.com/liluzivert/secure-the-bag-produced-by-glohan-beats").getId());
|
||||
assertEquals("294488438", linkHandler.fromUrl("HtTpS://sOuNdClOuD.cOm/LiLuZiVeRt/In-O4-pRoDuCeD-bY-dP-bEaTz").getId());
|
||||
assertEquals("294488147", linkHandler.fromUrl("https://soundcloud.com/liluzivert/fresh-produced-by-zaytoven#t=69").getId());
|
||||
assertEquals("294487876", linkHandler.fromUrl("https://soundcloud.com/liluzivert/threesome-produced-by-zaytoven#t=1:09").getId());
|
||||
assertEquals("294487684", linkHandler.fromUrl("https://soundcloud.com/liluzivert/blonde-brigitte-produced-manny-fresh#t=1:9").getId());
|
||||
assertEquals("294487428", linkHandler.fromUrl("https://soundcloud.com/liluzivert/today-produced-by-c-note#t=1m9s").getId());
|
||||
assertEquals("294487157", linkHandler.fromUrl("https://soundcloud.com/liluzivert/changed-my-phone-produced-by-c-note#t=1m09s").getId());
|
||||
assertEquals("44556776", linkHandler.fromUrl("https://soundcloud.com/kechuspider-sets-1/last-days").getId());
|
||||
@ParameterizedTest
|
||||
@CsvSource(value = {
|
||||
"309689103,https://soundcloud.com/liluzivert/15-ysl",
|
||||
"309689082,https://www.soundcloud.com/liluzivert/15-luv-scars-ko",
|
||||
"309689035,http://soundcloud.com/liluzivert/15-boring-shit",
|
||||
"259273264,https://soundcloud.com/liluzivert/ps-qs-produced-by-don-cannon/",
|
||||
"294488599,http://www.soundcloud.com/liluzivert/secure-the-bag-produced-by-glohan-beats",
|
||||
"245710200,HtTpS://sOuNdClOuD.cOm/lIeuTeNaNt_rAe/bOtS-wAs-wOlLeN-wIr-tRinKeN",
|
||||
"294488147,https://soundcloud.com/liluzivert/fresh-produced-by-zaytoven#t=69",
|
||||
"294487876,https://soundcloud.com/liluzivert/threesome-produced-by-zaytoven#t=1:09",
|
||||
"294487684,https://soundcloud.com/liluzivert/blonde-brigitte-produced-manny-fresh#t=1:9",
|
||||
"294487428,https://soundcloud.com/liluzivert/today-produced-by-c-note#t=1m9s",
|
||||
"294487157,https://soundcloud.com/liluzivert/changed-my-phone-produced-by-c-note#t=1m09s",
|
||||
"44556776,https://soundcloud.com/kechuspider-sets-1/last-days"
|
||||
})
|
||||
void getId(final String expectedId, final String url) throws ParsingException {
|
||||
assertEquals(expectedId, linkHandler.fromUrl(url).getId());
|
||||
}
|
||||
|
||||
|
||||
@Test
|
||||
public void testAcceptUrl() throws ParsingException {
|
||||
assertTrue(linkHandler.acceptUrl("https://soundcloud.com/liluzivert/15-ysl"));
|
||||
assertTrue(linkHandler.acceptUrl("https://www.soundcloud.com/liluzivert/15-luv-scars-ko"));
|
||||
assertTrue(linkHandler.acceptUrl("http://soundcloud.com/liluzivert/15-boring-shit"));
|
||||
assertTrue(linkHandler.acceptUrl("http://www.soundcloud.com/liluzivert/secure-the-bag-produced-by-glohan-beats"));
|
||||
assertTrue(linkHandler.acceptUrl("HtTpS://sOuNdClOuD.cOm/LiLuZiVeRt/In-O4-pRoDuCeD-bY-dP-bEaTz"));
|
||||
assertTrue(linkHandler.acceptUrl("https://soundcloud.com/liluzivert/fresh-produced-by-zaytoven#t=69"));
|
||||
assertTrue(linkHandler.acceptUrl("https://soundcloud.com/liluzivert/threesome-produced-by-zaytoven#t=1:09"));
|
||||
assertTrue(linkHandler.acceptUrl("https://soundcloud.com/liluzivert/blonde-brigitte-produced-manny-fresh#t=1:9"));
|
||||
assertTrue(linkHandler.acceptUrl("https://soundcloud.com/liluzivert/today-produced-by-c-note#t=1m9s"));
|
||||
assertTrue(linkHandler.acceptUrl("https://soundcloud.com/liluzivert/changed-my-phone-produced-by-c-note#t=1m09s"));
|
||||
@ParameterizedTest
|
||||
@ValueSource(strings = {
|
||||
"https://soundcloud.com/liluzivert/15-ysl",
|
||||
"https://www.soundcloud.com/liluzivert/15-luv-scars-ko",
|
||||
"http://soundcloud.com/liluzivert/15-boring-shit",
|
||||
"http://www.soundcloud.com/liluzivert/secure-the-bag-produced-by-glohan-beats",
|
||||
"HtTpS://sOuNdClOuD.cOm/LiLuZiVeRt/In-O4-pRoDuCeD-bY-dP-bEaTz",
|
||||
"https://soundcloud.com/liluzivert/fresh-produced-by-zaytoven#t=69",
|
||||
"https://soundcloud.com/liluzivert/threesome-produced-by-zaytoven#t=1:09",
|
||||
"https://soundcloud.com/liluzivert/blonde-brigitte-produced-manny-fresh#t=1:9",
|
||||
"https://soundcloud.com/liluzivert/today-produced-by-c-note#t=1m9s",
|
||||
"https://soundcloud.com/liluzivert/changed-my-phone-produced-by-c-note#t=1m09s"
|
||||
})
|
||||
void testAcceptUrl(final String url) throws ParsingException {
|
||||
assertTrue(linkHandler.acceptUrl(url));
|
||||
}
|
||||
}
|
||||
Loading…
Reference in New Issue