From 3b2cfb4ca2e9fbe9457e2a4551d97f7fa8bc6fec Mon Sep 17 00:00:00 2001 From: Stypox Date: Thu, 9 Apr 2020 18:15:34 +0200 Subject: [PATCH] [SoundCloud] Return empty video stream list instead of null Also replace every instance of `return new ArrayList<>();` with `return Collections.emptyList();` --- .../media_ccc/extractors/MediaCCCStreamExtractor.java | 4 ++-- .../soundcloud/extractors/SoundcloudStreamExtractor.java | 6 +++--- .../services/youtube/extractors/YoutubeStreamExtractor.java | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/extractor/src/main/java/org/schabi/newpipe/extractor/services/media_ccc/extractors/MediaCCCStreamExtractor.java b/extractor/src/main/java/org/schabi/newpipe/extractor/services/media_ccc/extractors/MediaCCCStreamExtractor.java index 042c5cd1..18aa9708 100644 --- a/extractor/src/main/java/org/schabi/newpipe/extractor/services/media_ccc/extractors/MediaCCCStreamExtractor.java +++ b/extractor/src/main/java/org/schabi/newpipe/extractor/services/media_ccc/extractors/MediaCCCStreamExtractor.java @@ -277,8 +277,8 @@ public class MediaCCCStreamExtractor extends StreamExtractor { @Nonnull @Override - public List getTags() { - return new ArrayList<>(); + public List getTags() throws ParsingException { + return Collections.emptyList(); } @Nonnull diff --git a/extractor/src/main/java/org/schabi/newpipe/extractor/services/soundcloud/extractors/SoundcloudStreamExtractor.java b/extractor/src/main/java/org/schabi/newpipe/extractor/services/soundcloud/extractors/SoundcloudStreamExtractor.java index d909acfc..0eaf1d9d 100644 --- a/extractor/src/main/java/org/schabi/newpipe/extractor/services/soundcloud/extractors/SoundcloudStreamExtractor.java +++ b/extractor/src/main/java/org/schabi/newpipe/extractor/services/soundcloud/extractors/SoundcloudStreamExtractor.java @@ -235,12 +235,12 @@ public class SoundcloudStreamExtractor extends StreamExtractor { @Override public List getVideoStreams() throws IOException, ExtractionException { - return null; + return Collections.emptyList(); } @Override public List getVideoOnlyStreams() throws IOException, ExtractionException { - return null; + return Collections.emptyList(); } @Override @@ -304,7 +304,7 @@ public class SoundcloudStreamExtractor extends StreamExtractor { @Nonnull @Override public List getTags() throws ParsingException { - return new ArrayList<>(); + return Collections.emptyList(); } @Nonnull diff --git a/extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeStreamExtractor.java b/extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeStreamExtractor.java index b2b5e4c4..f49812fc 100644 --- a/extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeStreamExtractor.java +++ b/extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeStreamExtractor.java @@ -1087,7 +1087,7 @@ public class YoutubeStreamExtractor extends StreamExtractor { @Nonnull @Override public List getTags() { - return new ArrayList<>(); + return Collections.emptyList(); } @Nonnull