From 5be1551fb4ea535659b122a1f4026aca2be9f611 Mon Sep 17 00:00:00 2001 From: ayman abdelghany Date: Thu, 2 Jun 2016 13:41:14 +0200 Subject: [PATCH] [squid:S1118] Utility classes should not have public constructors --- src/main/java/jd/cli/util/ClassFileUtil.java | 9 ++++++--- src/main/java/jd/cli/util/CommonTypeNameUtil.java | 3 +++ src/main/java/jd/cli/util/VersionUtil.java | 3 +++ .../java/org/apache/commons/cli/OptionValidator.java | 3 +++ .../org/apache/commons/cli/PatternOptionBuilder.java | 3 +++ src/main/java/org/apache/commons/cli/TypeHandler.java | 3 +++ src/main/java/org/apache/commons/cli/Util.java | 3 +++ .../apache/commons/codec/binary/CharSequenceUtils.java | 3 +++ .../org/apache/commons/codec/binary/StringUtils.java | 3 +++ .../org/apache/commons/codec/digest/DigestUtils.java | 3 +++ .../java/org/apache/commons/codec/digest/HmacUtils.java | 3 +++ .../org/apache/commons/codec/language/SoundexUtils.java | 3 +++ src/main/java/org/apache/commons/codec/net/Utils.java | 3 +++ .../the/bytecode/club/bytecodeviewer/BytecodeViewer.java | 3 +++ .../java/the/bytecode/club/bytecodeviewer/JarUtils.java | 3 +++ .../java/the/bytecode/club/bytecodeviewer/MiscUtils.java | 3 +++ .../bytecode/club/bytecodeviewer/api/BytecodeViewer.java | 3 +++ .../decompilers/bytecode/FieldNodeDecompiler.java | 5 ++++- .../club/bytecodeviewer/plugin/PluginManager.java | 5 ++++- 19 files changed, 62 insertions(+), 5 deletions(-) diff --git a/src/main/java/jd/cli/util/ClassFileUtil.java b/src/main/java/jd/cli/util/ClassFileUtil.java index 76e62044..396795ea 100644 --- a/src/main/java/jd/cli/util/ClassFileUtil.java +++ b/src/main/java/jd/cli/util/ClassFileUtil.java @@ -12,10 +12,13 @@ import java.io.*; public class ClassFileUtil { + private ClassFileUtil() { + } + /* - * Lecture rapide de la structure de la classe et extraction du nom du - * repoertoire de base. - */ + * Lecture rapide de la structure de la classe et extraction du nom du + * repoertoire de base. + */ public static String ExtractDirectoryPath(String pathToClass) throws Exception { DataInputStream dis = null; String directoryPath = null; diff --git a/src/main/java/jd/cli/util/CommonTypeNameUtil.java b/src/main/java/jd/cli/util/CommonTypeNameUtil.java index 9a20d83d..33d7e8cb 100644 --- a/src/main/java/jd/cli/util/CommonTypeNameUtil.java +++ b/src/main/java/jd/cli/util/CommonTypeNameUtil.java @@ -4,6 +4,9 @@ import jd.core.util.TypeNameUtil; public class CommonTypeNameUtil { + private CommonTypeNameUtil() { + } + public static String InternalPathToQualifiedTypeName(String internalPath) { String internalTypeName = internalPath.substring(0, internalPath.length()-6); diff --git a/src/main/java/jd/cli/util/VersionUtil.java b/src/main/java/jd/cli/util/VersionUtil.java index 1fe47db3..532c3f3a 100644 --- a/src/main/java/jd/cli/util/VersionUtil.java +++ b/src/main/java/jd/cli/util/VersionUtil.java @@ -2,6 +2,9 @@ package jd.cli.util; public class VersionUtil { + private VersionUtil() { + } + public static String getJDKVersion(int majorVersion, int minorVersion) { StringBuffer sb = new StringBuffer(20); diff --git a/src/main/java/org/apache/commons/cli/OptionValidator.java b/src/main/java/org/apache/commons/cli/OptionValidator.java index 659ee43c..88c3c978 100644 --- a/src/main/java/org/apache/commons/cli/OptionValidator.java +++ b/src/main/java/org/apache/commons/cli/OptionValidator.java @@ -25,6 +25,9 @@ package org.apache.commons.cli; */ final class OptionValidator { + private OptionValidator() { + } + /** * Validates whether opt is a permissible Option * shortOpt. The rules that specify if the opt diff --git a/src/main/java/org/apache/commons/cli/PatternOptionBuilder.java b/src/main/java/org/apache/commons/cli/PatternOptionBuilder.java index 6a5c4cee..83373223 100644 --- a/src/main/java/org/apache/commons/cli/PatternOptionBuilder.java +++ b/src/main/java/org/apache/commons/cli/PatternOptionBuilder.java @@ -87,6 +87,9 @@ public class PatternOptionBuilder /** URL class */ public static final Class URL_VALUE = URL.class; + private PatternOptionBuilder() { + } + /** * Retrieve the class that ch represents. * diff --git a/src/main/java/org/apache/commons/cli/TypeHandler.java b/src/main/java/org/apache/commons/cli/TypeHandler.java index ce36c167..3c9b7776 100644 --- a/src/main/java/org/apache/commons/cli/TypeHandler.java +++ b/src/main/java/org/apache/commons/cli/TypeHandler.java @@ -32,6 +32,9 @@ import java.util.Date; */ public class TypeHandler { + private TypeHandler() { + } + /** * Returns the Object of type obj * with the value of str. diff --git a/src/main/java/org/apache/commons/cli/Util.java b/src/main/java/org/apache/commons/cli/Util.java index 89cf5ff3..40841007 100644 --- a/src/main/java/org/apache/commons/cli/Util.java +++ b/src/main/java/org/apache/commons/cli/Util.java @@ -24,6 +24,9 @@ package org.apache.commons.cli; */ final class Util { + private Util() { + } + /** * Remove the hyphens from the beginning of str and * return the new String. diff --git a/src/main/java/org/apache/commons/codec/binary/CharSequenceUtils.java b/src/main/java/org/apache/commons/codec/binary/CharSequenceUtils.java index b886a826..a693c0e8 100644 --- a/src/main/java/org/apache/commons/codec/binary/CharSequenceUtils.java +++ b/src/main/java/org/apache/commons/codec/binary/CharSequenceUtils.java @@ -29,6 +29,9 @@ package org.apache.commons.codec.binary; */ public class CharSequenceUtils { + private CharSequenceUtils() { + } + /** * Green implementation of regionMatches. * diff --git a/src/main/java/org/apache/commons/codec/binary/StringUtils.java b/src/main/java/org/apache/commons/codec/binary/StringUtils.java index 8d692561..ec24811c 100644 --- a/src/main/java/org/apache/commons/codec/binary/StringUtils.java +++ b/src/main/java/org/apache/commons/codec/binary/StringUtils.java @@ -38,6 +38,9 @@ import java.nio.charset.Charset; */ public class StringUtils { + private StringUtils() { + } + /** *

* Compares two CharSequences, returning true if they represent equal sequences of characters. diff --git a/src/main/java/org/apache/commons/codec/digest/DigestUtils.java b/src/main/java/org/apache/commons/codec/digest/DigestUtils.java index d01bde4d..8e9a1ebc 100644 --- a/src/main/java/org/apache/commons/codec/digest/DigestUtils.java +++ b/src/main/java/org/apache/commons/codec/digest/DigestUtils.java @@ -36,6 +36,9 @@ public class DigestUtils { private static final int STREAM_BUFFER_LENGTH = 1024; + private DigestUtils() { + } + /** * Read through an ByteBuffer and returns the digest for the data * diff --git a/src/main/java/org/apache/commons/codec/digest/HmacUtils.java b/src/main/java/org/apache/commons/codec/digest/HmacUtils.java index 283bf90d..9e382a6a 100644 --- a/src/main/java/org/apache/commons/codec/digest/HmacUtils.java +++ b/src/main/java/org/apache/commons/codec/digest/HmacUtils.java @@ -44,6 +44,9 @@ public final class HmacUtils { private static final int STREAM_BUFFER_LENGTH = 1024; + private HmacUtils() { + } + /** * Returns an initialized Mac for the HmacMD5 algorithm. *

diff --git a/src/main/java/org/apache/commons/codec/language/SoundexUtils.java b/src/main/java/org/apache/commons/codec/language/SoundexUtils.java index 6409eb24..0e17df1e 100644 --- a/src/main/java/org/apache/commons/codec/language/SoundexUtils.java +++ b/src/main/java/org/apache/commons/codec/language/SoundexUtils.java @@ -30,6 +30,9 @@ import org.apache.commons.codec.StringEncoder; */ final class SoundexUtils { + private SoundexUtils() { + } + /** * Cleans up the input string before Soundex processing by only returning * upper case letters. diff --git a/src/main/java/org/apache/commons/codec/net/Utils.java b/src/main/java/org/apache/commons/codec/net/Utils.java index c482c0ab..a927468a 100644 --- a/src/main/java/org/apache/commons/codec/net/Utils.java +++ b/src/main/java/org/apache/commons/codec/net/Utils.java @@ -29,6 +29,9 @@ import org.apache.commons.codec.DecoderException; */ class Utils { + private Utils() { + } + /** * Returns the numeric value of the character b in radix 16. * diff --git a/src/main/java/the/bytecode/club/bytecodeviewer/BytecodeViewer.java b/src/main/java/the/bytecode/club/bytecodeviewer/BytecodeViewer.java index 879af25b..aff22a65 100644 --- a/src/main/java/the/bytecode/club/bytecodeviewer/BytecodeViewer.java +++ b/src/main/java/the/bytecode/club/bytecodeviewer/BytecodeViewer.java @@ -141,6 +141,9 @@ public class BytecodeViewer { public static boolean pingback = false; public static boolean deleteForiegnLibraries = true; + private BytecodeViewer() { + } + /** * Main startup * diff --git a/src/main/java/the/bytecode/club/bytecodeviewer/JarUtils.java b/src/main/java/the/bytecode/club/bytecodeviewer/JarUtils.java index 4fbbe88c..bc6c69b8 100644 --- a/src/main/java/the/bytecode/club/bytecodeviewer/JarUtils.java +++ b/src/main/java/the/bytecode/club/bytecodeviewer/JarUtils.java @@ -41,6 +41,9 @@ import java.util.zip.ZipInputStream; public class JarUtils { + private JarUtils() { + } + /** * Loads the classes and resources from the input jar file * @param jarFile the input jar file diff --git a/src/main/java/the/bytecode/club/bytecodeviewer/MiscUtils.java b/src/main/java/the/bytecode/club/bytecodeviewer/MiscUtils.java index 32b4d20c..a62cf50b 100644 --- a/src/main/java/the/bytecode/club/bytecodeviewer/MiscUtils.java +++ b/src/main/java/the/bytecode/club/bytecodeviewer/MiscUtils.java @@ -36,6 +36,9 @@ public class MiscUtils { private static final String AN = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789"; private static Random rnd = new Random(); + private MiscUtils() { + } + /** * Returns a random string without numbers * @param len the length of the String diff --git a/src/main/java/the/bytecode/club/bytecodeviewer/api/BytecodeViewer.java b/src/main/java/the/bytecode/club/bytecodeviewer/api/BytecodeViewer.java index 51a7d43f..48c123a8 100644 --- a/src/main/java/the/bytecode/club/bytecodeviewer/api/BytecodeViewer.java +++ b/src/main/java/the/bytecode/club/bytecodeviewer/api/BytecodeViewer.java @@ -45,6 +45,9 @@ public class BytecodeViewer { private static URLClassLoader cl; + private BytecodeViewer() { + } + /** * Grab the loader instance * diff --git a/src/main/java/the/bytecode/club/bytecodeviewer/decompilers/bytecode/FieldNodeDecompiler.java b/src/main/java/the/bytecode/club/bytecodeviewer/decompilers/bytecode/FieldNodeDecompiler.java index 9cf4da55..1f1bf75b 100644 --- a/src/main/java/the/bytecode/club/bytecodeviewer/decompilers/bytecode/FieldNodeDecompiler.java +++ b/src/main/java/the/bytecode/club/bytecodeviewer/decompilers/bytecode/FieldNodeDecompiler.java @@ -34,8 +34,11 @@ import java.util.List; public class FieldNodeDecompiler { + private FieldNodeDecompiler() { + } + public static PrefixedStringBuilder decompile(PrefixedStringBuilder sb, - FieldNode f) { + FieldNode f) { String s = getAccessString(f.access); sb.append(s); if (s.length() > 0) diff --git a/src/main/java/the/bytecode/club/bytecodeviewer/plugin/PluginManager.java b/src/main/java/the/bytecode/club/bytecodeviewer/plugin/PluginManager.java index 2b74df77..6e5e22ef 100644 --- a/src/main/java/the/bytecode/club/bytecodeviewer/plugin/PluginManager.java +++ b/src/main/java/the/bytecode/club/bytecodeviewer/plugin/PluginManager.java @@ -61,7 +61,10 @@ public final class PluginManager { launchStrategies.put("rb", ruby); launchStrategies.put("ruby", ruby); } - + + private PluginManager() { + } + /** * Runs a new plugin instance * @param newPluginInstance the new plugin instance