Security Manager Cleanup

src/main/java/the/bytecode/club/bytecodeviewer/Constants.java

@@ -73,13 +73,14 @@ public class Constants
 	 */
 	private static void hideFile(File f)
 	{
-		BytecodeViewer.sm.pauseBlocking();
 		try {
+			BytecodeViewer.sm.pauseBlocking();
 			// Hide file by running attrib system command (on Windows)
 			Runtime.getRuntime().exec("attrib +H " + f.getAbsolutePath());
 		} catch (Exception e) {
 			BytecodeViewer.handleException(e);
-		}
+		} finally {
 			BytecodeViewer.sm.resumeBlocking();
 		}
 	}
+}

src/main/java/the/bytecode/club/bytecodeviewer/compilers/impl/JavaCompiler.java

@@ -68,8 +68,8 @@ public class JavaCompiler extends InternalCompiler
         JarUtils.saveAsJar(BytecodeViewer.getLoadedClasses(), cp.getAbsolutePath());
 
         boolean cont = true;
-        BytecodeViewer.sm.pauseBlocking();
         try {
+            BytecodeViewer.sm.pauseBlocking();
             StringBuilder log = new StringBuilder();
             ProcessBuilder pb;
 

src/main/java/the/bytecode/club/bytecodeviewer/compilers/impl/KrakatauAssembler.java

@@ -65,9 +65,9 @@ public class KrakatauAssembler extends InternalCompiler
     
         StringBuilder log = new StringBuilder();
         
-        BytecodeViewer.sm.pauseBlocking();
         try
         {
+            BytecodeViewer.sm.pauseBlocking();
             ProcessBuilder pb = new ProcessBuilder(
                     Configuration.python2,
                     "-O", //love you storyyeller <3

src/main/java/the/bytecode/club/bytecodeviewer/decompilers/impl/FernFlowerDecompiler.java

@@ -88,12 +88,12 @@ public class FernFlowerDecompiler extends InternalDecompiler
         {
             try
             {
+                BytecodeViewer.sm.pauseBlocking();
                 ProcessBuilder pb = new ProcessBuilder(ArrayUtils.addAll(
                         new String[]{ExternalResources.getSingleton().getJavaCommand(true), "-jar", ExternalResources.getSingleton().findLibrary("fernflower")},
                         generateMainMethod(tempClass.getAbsolutePath(),
                                 new File(tempDirectory).getAbsolutePath())
                 ));
-                BytecodeViewer.sm.pauseBlocking();
                 Process p = pb.start();
                 BytecodeViewer.createdProcesses.add(p);
                 p.waitFor();

src/main/java/the/bytecode/club/bytecodeviewer/decompilers/impl/KrakatauDecompiler.java

@@ -91,8 +91,8 @@ public class KrakatauDecompiler extends InternalDecompiler
 
         String s = ExceptionUI.SEND_STACKTRACE_TO_NL;
 
-        BytecodeViewer.sm.pauseBlocking();
         try {
+            BytecodeViewer.sm.pauseBlocking();
             ProcessBuilder pb = new ProcessBuilder(
                     Configuration.python2,
                     "-O", //love you storyyeller <3
@@ -171,9 +171,8 @@ public class KrakatauDecompiler extends InternalDecompiler
 
         JarUtils.saveAsJarClassesOnly(BytecodeViewer.getLoadedClasses(), tempJar.getAbsolutePath());
 
-        BytecodeViewer.sm.pauseBlocking();
-
         try {
+            BytecodeViewer.sm.pauseBlocking();
             ProcessBuilder pb = new ProcessBuilder(
                     Configuration.python2,
                     "-O", //love you storyyeller <3
@@ -247,12 +246,10 @@ public class KrakatauDecompiler extends InternalDecompiler
         final File tempDirectory = new File(Constants.tempDirectory + fs + ran + fs);
         tempDirectory.mkdir();
 
-
         final File tempJar = new File(sourceJar);
         
-        BytecodeViewer.sm.pauseBlocking();
-
         try {
+            BytecodeViewer.sm.pauseBlocking();
             ProcessBuilder pb = new ProcessBuilder(
                     Configuration.python2,
                     "-O", //love you storyyeller <3

src/main/java/the/bytecode/club/bytecodeviewer/decompilers/impl/KrakatauDisassembler.java

@@ -58,8 +58,8 @@ public class KrakatauDisassembler extends InternalDecompiler
         final File tempJar = new File(Constants.tempDirectory + fs + "temp" + MiscUtils.randomString(32) + ".jar");
         JarUtils.saveAsJarClassesOnly(BytecodeViewer.getLoadedClasses(), tempJar.getAbsolutePath());
 
-        BytecodeViewer.sm.pauseBlocking();
         try {
+            BytecodeViewer.sm.pauseBlocking();
             ProcessBuilder pb = new ProcessBuilder(
                     Configuration.python2,
                     "-O", //love you storyyeller <3
@@ -122,8 +122,8 @@ public class KrakatauDisassembler extends InternalDecompiler
 
         final File tempJar = new File(sourceJar);
 
-        BytecodeViewer.sm.pauseBlocking();
         try {
+            BytecodeViewer.sm.pauseBlocking();
             ProcessBuilder pb = new ProcessBuilder(
                     Configuration.python2,
                     "-O", //love you storyyeller <3

src/main/java/the/bytecode/club/bytecodeviewer/resources/ExternalResources.java

@@ -57,9 +57,9 @@ public class ExternalResources
 		if(!empty)
 			return Configuration.java;
 		
-		BytecodeViewer.sm.pauseBlocking();
 		try
 		{
+			BytecodeViewer.sm.pauseBlocking();
 			//TODO read the version output to verify it exists
 			ProcessBuilder pb = new ProcessBuilder("java", "-version");
 			pb.start();

src/main/java/the/bytecode/club/bytecodeviewer/util/Enjarify.java

@@ -50,8 +50,8 @@ public class Enjarify {
             return;
         }
 
-        BytecodeViewer.sm.pauseBlocking();
         try {
+            BytecodeViewer.sm.pauseBlocking();
             ProcessBuilder pb = new ProcessBuilder(
                     Configuration.python3,
                     "-O",