Cynosphere/bcv-vf
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Merge pull request #365 from lujiefsi/JRTExtractor

Browse source 
resource leak due to Files.walk
This commit is contained in:
Konloch 2021-10-26 22:54:17 -07:00 committed by GitHub
commit 36515d09d5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/main/java/the/bytecode/club/bytecodeviewer/util/JRTExtractor.java
View file

@ -18,9 +18,11 @@ import java.net.URI;
import java.nio.file.FileSystem; import java.nio.file.FileSystem;
import java.nio.file.FileSystems; import java.nio.file.FileSystems;
import java.nio.file.Files; import java.nio.file.Files;
import java.nio.file.Path;
import java.nio.file.Paths; import java.nio.file.Paths;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.List; import java.util.List;
import java.util.stream.Stream;
import java.util.zip.ZipEntry; import java.util.zip.ZipEntry;
import java.util.zip.ZipOutputStream; import java.util.zip.ZipOutputStream;
@ -28,8 +30,9 @@ public class JRTExtractor {
public static void extractRT(String path) throws Throwable { public static void extractRT(String path) throws Throwable {
FileSystem fs = FileSystems.getFileSystem(URI.create("jrt:/")); FileSystem fs = FileSystems.getFileSystem(URI.create("jrt:/"));
try (ZipOutputStream zipStream = new ZipOutputStream(Files.newOutputStream(Paths.get(path)))) { try (ZipOutputStream zipStream = new ZipOutputStream(Files.newOutputStream(Paths.get(path)));
Files.walk(fs.getPath("/")).forEach(p -> { Stream<Path> stream = Files.walk(fs.getPath("/"))) {
stream.forEach(p -> {
if (!Files.isRegularFile(p)) { if (!Files.isRegularFile(p)) {
return; return;
} }