From 35bf1b455ecc981dbbfd573ba918480fb01f7ca0 Mon Sep 17 00:00:00 2001
From: AJ Ferguson <fergusonjva@gmail.com>
Date: Thu, 13 Feb 2020 17:04:22 -0900
Subject: [PATCH] Fix new player entity data getting lost while loading skin

---
 .../java/org/geysermc/connector/entity/Entity.java    | 11 ++++++++++-
 .../org/geysermc/connector/entity/PlayerEntity.java   |  5 ++++-
 .../connector/network/session/cache/EntityCache.java  |  6 +++++-
 .../java/entity/JavaEntityMetadataTranslator.java     |  8 ++------
 .../java/entity/JavaEntityPropertiesTranslator.java   |  2 +-
 .../java/entity/spawn/JavaSpawnPlayerTranslator.java  |  1 +
 6 files changed, 23 insertions(+), 10 deletions(-)

diff --git a/connector/src/main/java/org/geysermc/connector/entity/Entity.java b/connector/src/main/java/org/geysermc/connector/entity/Entity.java
index 47b39874..057a0663 100644
--- a/connector/src/main/java/org/geysermc/connector/entity/Entity.java
+++ b/connector/src/main/java/org/geysermc/connector/entity/Entity.java
@@ -154,6 +154,8 @@ public class Entity {
     }
 
     public void updateBedrockAttributes(GeyserSession session) {
+        if (!valid) return;
+
         List<com.nukkitx.protocol.bedrock.data.Attribute> attributes = new ArrayList<>();
         for (Map.Entry<AttributeType, Attribute> entry : this.attributes.entrySet()) {
             if (!entry.getValue().getType().isBedrockAttribute())
@@ -191,7 +193,8 @@ public class Entity {
                     metadata.put(EntityData.NAMETAG, MessageUtils.getBedrockMessage(name));
                 break;
             case 3: // is custom name visible
-                metadata.put(EntityData.ALWAYS_SHOW_NAMETAG, (byte) ((boolean) entityMetadata.getValue() ? 1 : 0));
+                if (!this.is(PlayerEntity.class))
+                    metadata.put(EntityData.ALWAYS_SHOW_NAMETAG, (byte) ((boolean) entityMetadata.getValue() ? 1 : 0));
                 break;
             case 4: // silent
                 metadata.getFlags().setFlag(EntityFlag.SILENT, (boolean) entityMetadata.getValue());
@@ -201,6 +204,12 @@ public class Entity {
                 break;
         }
 
+        updateBedrockMetadata(session);
+    }
+
+    public void updateBedrockMetadata(GeyserSession session) {
+        if (!valid) return;
+
         SetEntityDataPacket entityDataPacket = new SetEntityDataPacket();
         entityDataPacket.setRuntimeEntityId(geyserId);
         entityDataPacket.getMetadata().putAll(metadata);
diff --git a/connector/src/main/java/org/geysermc/connector/entity/PlayerEntity.java b/connector/src/main/java/org/geysermc/connector/entity/PlayerEntity.java
index 67dc0894..20583002 100644
--- a/connector/src/main/java/org/geysermc/connector/entity/PlayerEntity.java
+++ b/connector/src/main/java/org/geysermc/connector/entity/PlayerEntity.java
@@ -81,10 +81,13 @@ public class PlayerEntity extends LivingEntity {
         addPlayerPacket.setCustomFlags(0);
         addPlayerPacket.setDeviceId("");
         addPlayerPacket.setPlatformChatId("");
-        addPlayerPacket.getMetadata().putAll(getMetadata());
+        addPlayerPacket.getMetadata().putAll(metadata);
 
         valid = true;
         session.getUpstream().sendPacket(addPlayerPacket);
+
+        updateEquipment(session);
+        updateBedrockAttributes(session);
     }
 
     public void sendPlayer(GeyserSession session) {
diff --git a/connector/src/main/java/org/geysermc/connector/network/session/cache/EntityCache.java b/connector/src/main/java/org/geysermc/connector/network/session/cache/EntityCache.java
index cba6b7b6..2834cb90 100644
--- a/connector/src/main/java/org/geysermc/connector/network/session/cache/EntityCache.java
+++ b/connector/src/main/java/org/geysermc/connector/network/session/cache/EntityCache.java
@@ -56,9 +56,13 @@ public class EntityCache {
 
     public void spawnEntity(Entity entity) {
         entity.moveAbsolute(entity.getPosition(), entity.getRotation().getX(), entity.getRotation().getY());
+        cacheEntity(entity);
+        entity.spawnEntity(session);
+    }
+
+    public void cacheEntity(Entity entity) {
         entityIdTranslations.put(entity.getEntityId(), entity.getGeyserId());
         entities.put(entity.getGeyserId(), entity);
-        entity.spawnEntity(session);
     }
 
     public boolean removeEntity(Entity entity, boolean force) {
diff --git a/connector/src/main/java/org/geysermc/connector/network/translators/java/entity/JavaEntityMetadataTranslator.java b/connector/src/main/java/org/geysermc/connector/network/translators/java/entity/JavaEntityMetadataTranslator.java
index 0a55120d..d8d28fb7 100644
--- a/connector/src/main/java/org/geysermc/connector/network/translators/java/entity/JavaEntityMetadataTranslator.java
+++ b/connector/src/main/java/org/geysermc/connector/network/translators/java/entity/JavaEntityMetadataTranslator.java
@@ -41,12 +41,8 @@ public class JavaEntityMetadataTranslator extends PacketTranslator<ServerEntityM
         }
         if (entity == null) return;
 
-        if (entity.isValid()) {
-            for (EntityMetadata metadata : packet.getMetadata()) {
-                entity.updateBedrockMetadata(metadata, session);
-            }
-        } else {
-            entity.spawnEntity(session);
+        for (EntityMetadata metadata : packet.getMetadata()) {
+            entity.updateBedrockMetadata(metadata, session);
         }
     }
 }
diff --git a/connector/src/main/java/org/geysermc/connector/network/translators/java/entity/JavaEntityPropertiesTranslator.java b/connector/src/main/java/org/geysermc/connector/network/translators/java/entity/JavaEntityPropertiesTranslator.java
index 3d6ed206..c5c71f75 100644
--- a/connector/src/main/java/org/geysermc/connector/network/translators/java/entity/JavaEntityPropertiesTranslator.java
+++ b/connector/src/main/java/org/geysermc/connector/network/translators/java/entity/JavaEntityPropertiesTranslator.java
@@ -41,7 +41,7 @@ public class JavaEntityPropertiesTranslator extends PacketTranslator<ServerEntit
         if (packet.getEntityId() == session.getPlayerEntity().getEntityId()) {
             entity = session.getPlayerEntity();
         }
-        if (entity == null || !entity.isValid()) return;
+        if (entity == null) return;
 
         for (Attribute attribute : packet.getAttributes()) {
             switch (attribute.getType()) {
diff --git a/connector/src/main/java/org/geysermc/connector/network/translators/java/entity/spawn/JavaSpawnPlayerTranslator.java b/connector/src/main/java/org/geysermc/connector/network/translators/java/entity/spawn/JavaSpawnPlayerTranslator.java
index 7dea34ec..1e151868 100644
--- a/connector/src/main/java/org/geysermc/connector/network/translators/java/entity/spawn/JavaSpawnPlayerTranslator.java
+++ b/connector/src/main/java/org/geysermc/connector/network/translators/java/entity/spawn/JavaSpawnPlayerTranslator.java
@@ -50,6 +50,7 @@ public class JavaSpawnPlayerTranslator extends PacketTranslator<ServerSpawnPlaye
         entity.setEntityId(packet.getEntityId());
         entity.setPosition(position);
         entity.setRotation(rotation);
+        session.getEntityCache().cacheEntity(entity);
 
         // async skin loading
         if (session.getUpstream().isInitialized()) {