From 2f2164f38775442fd909f32267774dcc96d5fc6c Mon Sep 17 00:00:00 2001
From: Camotoy <20743703+DoctorMacc@users.noreply.github.com>
Date: Thu, 17 Sep 2020 23:07:20 -0400
Subject: [PATCH] InventoryUtils: Don't send Java packet on hotbar item
 selection (#1301)

The Bedrock client sends a confirmation packet we translate regardless.
---
 .../java/org/geysermc/connector/utils/InventoryUtils.java    | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/connector/src/main/java/org/geysermc/connector/utils/InventoryUtils.java b/connector/src/main/java/org/geysermc/connector/utils/InventoryUtils.java
index b3cc14b9..c1224e6e 100644
--- a/connector/src/main/java/org/geysermc/connector/utils/InventoryUtils.java
+++ b/connector/src/main/java/org/geysermc/connector/utils/InventoryUtils.java
@@ -27,7 +27,6 @@ package org.geysermc.connector.utils;
 
 import com.github.steveice10.mc.protocol.data.game.entity.metadata.ItemStack;
 import com.github.steveice10.mc.protocol.data.game.entity.player.GameMode;
-import com.github.steveice10.mc.protocol.packet.ingame.client.player.ClientPlayerChangeHeldItemPacket;
 import com.github.steveice10.mc.protocol.packet.ingame.client.window.ClientCreativeInventoryActionPacket;
 import com.github.steveice10.mc.protocol.packet.ingame.client.window.ClientMoveItemToHotbarPacket;
 import com.github.steveice10.opennbt.tag.builtin.CompoundTag;
@@ -241,8 +240,6 @@ public class InventoryUtils {
         hotbarPacket.setSelectedHotbarSlot(slot - 36);
         hotbarPacket.setSelectHotbarSlot(true);
         session.sendUpstreamPacket(hotbarPacket);
-        ClientPlayerChangeHeldItemPacket heldItemPacket = new ClientPlayerChangeHeldItemPacket(slot);
-        session.sendDownstreamPacket(heldItemPacket);
-        session.getInventory().setHeldItemSlot(slot - 36);
+        // No need to send a Java packet as Bedrock sends a confirmation packet back that we translate
     }
 }